Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename argument name in configuration_parser.check_flag_column() #485

Open
desilinguist opened this issue Nov 3, 2020 — with Slack · 0 comments
Open

Rename argument name in configuration_parser.check_flag_column() #485

desilinguist opened this issue Nov 3, 2020 — with Slack · 0 comments
Labels
enhancement

Comments

@desilinguist Slack
Copy link
Member

It's confusing that the name of the argument is flag_column and one of the values that it takes is also flag_column. This makes the docstring very confusing to write.

We should rename the argument to flag_column_name
@desilinguist desilinguist added the enhancement label Nov 3, 2020 — with Slack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@desilinguist