Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suppress_warnings argument to various metrics #411

Open
aloukina opened this issue Mar 19, 2020 · 1 comment
Open

Add suppress_warnings argument to various metrics #411

aloukina opened this issue Mar 19, 2020 · 1 comment

Comments

@aloukina
Copy link
Collaborator

aloukina commented Mar 19, 2020

The functions for computing individual metrics raise warning in edge cases (for example, when standard deviation is zero). In some cases this can result in multiple warnings which all have the same underlying cause. For example, in case of DSM the user will see a warning for each subgroup.

For users who call the tool from command line or using the top-level API function run_*, we could display a single warning pointing out the issue and suppress subsequent warnings raised by each function through an optional suppress_warnings argument. The default value will be False.

This would require carefully working through different metrics to make sure we do not suppress any unrelated warnings.

@desilinguist
Copy link
Member

Great idea! May be we should also have an overall verbose/quiet option on the command line for the run command that propagates all the way down into the code and appropriately sets this argument for the various methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants