Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Quality] Code/app tests #387

Open
1 task done
EdricChan03 opened this issue Mar 23, 2023 · 0 comments
Open
1 task done

[Quality] Code/app tests #387

EdricChan03 opened this issue Mar 23, 2023 · 0 comments
Labels
code health Issues/PRs related to improving code quality/health enhancement Enhancements to the Android app. For the web version, please use the other repo instead. good first issue Issues/PRs for new contributors to look at. help wanted Issues/ PRs that will benefit help from the community. question All questions related to the web version of the repo.

Comments

@EdricChan03
Copy link
Owner

Is there an existing issue for this?

  • I have searched the existing issues

Feature type

User interface/User experience

Problem

The app seems to be broken in various different ways on various versions of Android - for example, the updater no longer works as expected (#386)

Description

Investigate adding tests for existing and new features/code

Alternatives?

Manual testing, but this isn't really viable long-term

Additional info

It's a bit hard to account for different API levels :P
@EdricChan03 EdricChan03 added enhancement Enhancements to the Android app. For the web version, please use the other repo instead. help wanted Issues/ PRs that will benefit help from the community. question All questions related to the web version of the repo. priority: non-critical good first issue Issues/PRs for new contributors to look at. code health Issues/PRs related to improving code quality/health labels Mar 23, 2023
@EdricChan03 EdricChan03 changed the title [Quality] Code tests [Quality] Code/app tests Mar 23, 2023
EdricChan03 added a commit that referenced this issue Jun 18, 2023
@EdricChan03
AppIcon: Add instrumentation tests (#387)
df8917f 
Currently it only tests if it displays correctly
@EdricChan03 EdricChan03 moved this from Todo to In Progress in StudyBuddy Jun 18, 2023
EdricChan03 added a commit that referenced this issue Nov 13, 2023
@EdricChan03
Initial Compose variant of options bottom sheet UI
51755b6 
This is an initial port of the modal-bottom-sheet Gradle submodule to
use Compose.

* Selection state is now handled on the group data class as a list of
  indexes rather than a list of items, to allow for easier flexability.
  This ensures a single-source of truth for the list of items.

* An additional constructor was introduced to allow for a `Map` of key
  `BottomSheetOption` to whether it's selected (`Boolean`) (i.e.
  `Map<BottomSheetOption, Boolean>`.

See #368 and  #369

* Added unit + instrumentation tests for bottom sheet data + UI (#387)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code health Issues/PRs related to improving code quality/health enhancement Enhancements to the Android app. For the web version, please use the other repo instead. good first issue Issues/PRs for new contributors to look at. help wanted Issues/ PRs that will benefit help from the community. question All questions related to the web version of the repo.
Projects
StudyBuddy
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
1 participant
@EdricChan03