Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TelemetryService should insert into database using device name instead of SKU #778

Open
tomqin93 opened this issue Dec 7, 2023 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@tomqin93
Copy link
Contributor

tomqin93 commented Dec 7, 2023

Is your feature request related to a problem? Please describe.

Currently when we enable telemetryService for a device with SQL, the name of the entry will be the SKU of the device in edgeDevice. This makes it harder to manage when we have to identical devices with the same SKU

Describe the solution you'd like

The solution would be to use device name for now. Since they are unique for a Kubernetes cluster. For now let's keep it within a single cluster. We can add in cluster id in the future

Describe alternatives you've considered

Using a slightly different SKU number for different devices

Additional context

Should be fixed here https://github.com/Edgenesis/shifu/blob/main/pkg/deviceshifu/deviceshifubase/pushtelemetry.go#L26

@tomqin93 tomqin93 added help wanted Extra attention is needed good first issue Good for newcomers labels Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant