Looks ok. Might want to remove the extra blank lines added before the #endif though.

Removed Lines.

I'm somewhat doubting this now. min/max are loaded & saved without issue, which suits my purpose (a load/save lua script)

However the numbers are the values stored presumably in memory, not the numbers the user sees on the screen, somewhat like what was happening in #4379

I'm looking back and following function calls through the handling of gvars on and end up with the following calls:

• https://github.com/EdgeTX/edgetx/blob/0ea41f21464741ef68a3443dcb591b82cc6d3051/radio/src/gui/212x64/model_gvars.cpp#L103C9-L103C22

• edgetx/radio/src/gui/212x64/widgets.cpp

  Line 149 in 0ea41f2

  void drawGVarValue(coord_t x, coord_t y, uint8_t gvar, gvar_t value, LcdFlags flags)

• edgetx/radio/src/gui/212x64/widgets.cpp

  Line 149 in 0ea41f2

  void drawGVarValue(coord_t x, coord_t y, uint8_t gvar, gvar_t value, LcdFlags flags)

• edgetx/radio/src/gui/212x64/widgets.cpp

  Line 149 in 0ea41f2

  void drawGVarValue(coord_t x, coord_t y, uint8_t gvar, gvar_t value, LcdFlags flags)

But that last function is somewhat of a monster and while I see it is largely that do..while loop that does the work, I'm not confident in editing those functions and feel I cannot copy it either as it's somewhat complex.

I feel either the implementation is fine, but the table values should be prefixed with "raw" or ask assistance on how to get the API values out as what the user sees on screen (which would be preferable).

Sorry I hoped to do this by myself :-(

'unit' and 'prec' are not boolean values, they are integers (even though they are currently limited to be either 0 or 1).
I don't understand why you need to rename the 'min' and 'max' properties.

So, I am happy with the first 1st, 2nd or 3rd commits.

In the third commit I'm primarily looking at the user interface and noticing 2 things, as you say, unit and prec are integers, but displayed usage is as a boolean, so I thought that was better to have them as booleans. Happy to put them back to integers.

I also noticed that, getGlobalVariableDetails() the max value is represented as 124 when it would display 900 on screen (low precision). of course, using setGlobalVariableDetails() with a max of 124 will set it back to 900 (on screen). It's an integer in memory, but one that does not map directly to the screen / user perception... This is why I elected to rename it to raw_max, as it's not doing exactly what might be expected from a lua developer.

I'm working on an import/export script in lua and I don't really care, but am happy to go with either commit, or work with you or another team member to improve the API to be more obvious.

Let me know what you want to do.

Thanks

'unit' and 'prec' are not treated as boolean in the UI - they select from a choice of values. If they were booleans they would be represented as toggle switches in the UI.

The internal values for 'min' and 'max' are offsets from GVAR_MIN and GVAR_MAX respectively - this is so that the default (0) value stored map to the default minimum and maximum. The stored value range is 0 - 2048 in both cases.

If you want to work with the -1024 - 1024 range in the Lua script then just apply GVAR_MIN and GVAR_MAX when getting and setting these values.
E.G.: to get the values:

      int16_t vmin = GVAR_MIN + g_model.gvars[gvar].min;
      int16_t vmax = GVAR_MAX - g_model.gvars[gvar].max;

Changed with your recommendations, thanks :-)

@philmoz is it right/correct for this to be requested to merge into main and how do we get that to happen? Thanks and Thanks for your help so far 🙂

@philmoz is it right/correct for this to be requested to merge into main and how do we get that to happen? Thanks and Thanks for your help so far 🙂

@pfeerick will look after merging this when he has reviewed it (and has time).

Thanks and great.

Would you mind updating the inline documentation to be more like shown here please? Note that the double -- shown there are not needed.. since using the /*luadoc */ multiline comment block.

#5277

@pfeerick done. let me know if they're not correct. Thanks