Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate switch when you have a physically broken switch on your controller #3662

Closed
1 task done
jawz101 opened this issue Jun 5, 2023 · 6 comments · Fixed by #3715
Closed
1 task done

Deactivate switch when you have a physically broken switch on your controller #3662

jawz101 opened this issue Jun 5, 2023 · 6 comments · Fixed by #3715
Labels
enhancement ✨ New feature or request

Comments

@jawz101
Copy link

jawz101 commented Jun 5, 2023

Is there an existing issue for this feature request?

  • I have searched the existing issues

Is your feature request related to a problem?

I had a switch physically break on my TX16s which was my GPS Rescue switch. Consequently I had to delete its programming so that it wouldn't intermittently trigger since the remaining bits of it would wiggle around in its housing.

Describe the solution you'd like

I was wondering if there could be a way to disable switches w/in the setup screens so that it's easier to reenable the switch & retain its programming instead of deleting the switch's settings until the new part arrives.

Describe alternatives you've considered

delete switch settings

Additional context

No response

@jawz101 jawz101 added the enhancement ✨ New feature or request label Jun 5, 2023
@jawz101 jawz101 changed the title disable button on switch settings when you have a broken switch on your controller Deactivate switch when you have a physically broken switch on your controller Jun 5, 2023
@pfeerick
Copy link
Member

pfeerick commented Jun 6, 2023

I've not checked how the code functions, but have you tried turning the switch off in the radio setup -> hardware page - i.e. change the type from 2POS/3POS to NONE?

@philmoz
Copy link
Collaborator

philmoz commented Jun 6, 2023

I've not checked how the code functions, but have you tried turning the switch off in the radio setup -> hardware page - i.e. change the type from 2POS/3POS to NONE?

You need to restart the radio after changing this setting.
Also the affected switch will still exist but always be set to 0 - so a switch check for SA- would still succeed (for example).

@3djc
Copy link
Collaborator

3djc commented Jun 6, 2023

I think thats probably an issue. To me, a disabled (set to NONE) switch should not be evaluated at all

@gagarinlg
Copy link
Member

Which is currently not an option. We need a switch state "invalid" which always returns false on all comparisons

@3djc
Copy link
Collaborator

3djc commented Jun 6, 2023

Why ? None should do exactly that, imho

@3djc
Copy link
Collaborator

3djc commented Jun 11, 2023

Since switch handling is basically completely rewritten in ADC refactor, this has been handled there. This comit: c8e9437 adresses this issue.

  • Special function are not trigered by 'none' switch
  • In logical switches, 'none' switch is always false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants