Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimizing KL (not maximizing) #3

Open
sherjilozair opened this issue Nov 20, 2016 · 1 comment
Open

Minimizing KL (not maximizing) #3

sherjilozair opened this issue Nov 20, 2016 · 1 comment

Comments

@sherjilozair
Copy link

Thanks for uploading this. However, there is an error.

In the loss computation, you have elbo = data_dim * bce(x, x_hat) - KL.

It should be elbo = data_dim * bce(x, x_hat) + KL instead.
@adammenges
Copy link

just noticed this too, can submit a pr if wanted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sherjilozair @adammenges