Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Add dark color to github icon in footer #1081

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

BSlaven
Copy link
Member

@BSlaven BSlaven commented Feb 7, 2022

Closes #1072

Changes proposed

I added a dark color as className. But there is not black color as a utility (at least I did not find it). I added 'text-gray-900'.

One way to add black could be to use inline style as style={{ color: #000 }}.

There is a same icon in navbar. Should I change color of that one as well? Thoughts?

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

from this:

Screenshot (53)

to this:

Screenshot (2)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! Thanks for submitting a PR! 😄 Could you please show us a screenshot of how does it look before? Let us know if you need any help with anything. Thank you. :)

@BSlaven
Copy link
Member Author

BSlaven commented Feb 7, 2022

I've edited the PR body to show before and after this change.

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you for your contribution! 😄👍

@EmmaDawsonDev EmmaDawsonDev merged commit c863f5f into EddieHubCommunity:main Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update github icon color on main page
4 participants