Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

[FEATURE] Add location to in-person events #4132

Closed
ChinmayMhatre opened this issue Jan 27, 2023 · 26 comments
Closed

[FEATURE] Add location to in-person events #4132

ChinmayMhatre opened this issue Jan 27, 2023 · 26 comments
Assignees
Labels
💻 aspect: code undefined ⭐ goal: addition undefined good first issue undefined 🔢 points: 5 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)

Comments

@ChinmayMhatre
Copy link
Member

Description

Maybe we could add a location to the in person events?

Screenshot 2023-01-27 at 11 49 42 PM

Screenshots

No response

Additional information

No response

@github-actions
Copy link
Contributor

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@Pradumnasaraf
Copy link
Contributor

Pradumnasaraf commented Jan 27, 2023

Great point. Later with the data, we can also add to the live map to see which conferences are happening nearby.

@ShuvamChatterjee28
Copy link
Contributor

Can I try to do this one please @ChinmayMhatre and @Pradumnasaraf?

@Vishrut19
Copy link
Member

Hey ! Can I try to work on this issue ? @Pradumnasaraf

@eddiejaoude
Copy link
Member

I think the data we need to capture is...

"location": {
   "road": "",
   "city": "",
   "state": "",
   "country": ""
}

Please add to the docs also

@Vishrut19
Copy link
Member

I think the data we need to capture is...

"location": {
   "road": "",
   "city": "",
   "state": "",
   "country": ""
}

Please add to the docs also

okay @eddiejaoude I got some idea about it. Where can I discuss about it with you ?

@ShuvamChatterjee28
Copy link
Contributor

Hey @eddiejaoude, can you kindly assign me?

@Mutai-Gilbert
Copy link
Contributor

Hello @eddiejaoude, I'll be so happy to work on this issue. Kindly let me work on this.

@ChinmayMhatre
Copy link
Member Author

Can I try to do this one please @ChinmayMhatre and @Pradumnasaraf?

Hey @ShuvamChatterjee28 I can't assign it to you. But you can go ahead with this. If you want any help let us know. Thank you!

@Pradumnasaraf
Copy link
Contributor

Hey, @ShuvamChatterjee28 you can go ahead and others, please look for other issues.

Thank you!

@Vishrut19
Copy link
Member

Hey @Pradumnasaraf! @ShuvamChatterjee28 is already assigned and working on an issue i.e. issue number #4223. You can have a look at it.

@ShuvamChatterjee28
Copy link
Contributor

For #4223, the PR is created. Thanks. Working on this issue now.

@Vishrut19
Copy link
Member

Idk! what kind of system is this that you want to contribute to Open Source? Some folks are assigned more than one issue which is fine but if you are asking for an issue again and again but no one is assigning you. That's so cool! @Pradumnasaraf

@Pradumnasaraf
Copy link
Contributor

Pradumnasaraf commented Jan 30, 2023

Hey, @ShuvamChatterjee28,

@ShuvamChatterjee28 commented on the issue 1st, this is why they are been assigned. Also, I didn't know that they are already assigned to an issue, and people can work on 1-2 issues together.

You can look for other open issues. I know you are an enthusiast and want to contribute. Hope you understand.

@Vishrut19
Copy link
Member

Cool no problem @Pradumnasaraf and also I have found an issue. Where can I raise it ?

@Pradumnasaraf
Copy link
Contributor

Cool no problem @Pradumnasaraf and also I have found an issue. Where can I raise it ?

Here - https://github.com/EddieHubCommunity/LinkFree/issues/new/choose

@ShuvamChatterjee28
Copy link
Contributor

Hey @Pradumnasaraf and @eddiejaoude, I have made a working prototype of the location parameter in events. Also I have updated the docs too. Please have a look at the screenshot and let me know if you like it or not -->
Screenshot 2023-02-01 at 9 52 21 PM
(The Docs containing the location parameter. Now all the required flags are false, because I have set the code like, if isVirtual is set as true && isInPerson is false, then by fault the location will be remote)

Screenshot 2023-02-01 at 10 03 59 PM

(It is the layout of the events page containing the location)

Please suggest, if I should make any changes in the layout or not!

@ChinmayMhatre
Copy link
Member Author

Hey @ShuvamChatterjee28 , I think it would be best if you created a PR with your solution. The changes could be discussed over on the PR. Thanks

@ShuvamChatterjee28
Copy link
Contributor

Got it @ChinmayMhatre, will create a PR. Thanks.

@Pradumnasaraf
Copy link
Contributor

Yes, you can raise a draft PR!

@saaagarsingh
Copy link

Hey @ShuvamChatterjee28 just had a doubt what if event is in hybrid mode??? The logic will still show remote.

@ShuvamChatterjee28
Copy link
Contributor

Nope, it is updated now.

@SaraJaoude SaraJaoude added 💻 aspect: code undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) and removed EddieHub:good-first-issue labels Feb 27, 2023
@SaraJaoude SaraJaoude added the 🔢 points: 5 undefined label Feb 27, 2023
@ashutosh887
Copy link
Member

@eddiejaoude I would like to work on this

@eddiejaoude
Copy link
Member

eddiejaoude commented Mar 13, 2023

@ashutosh887 please read the history of the issue timeline, you will see it is already assigned and a pull request has already been created.

Please have a look at the issue list and select an issue that

  • is not already assigned (unless more than 2 weeks with no activity and we can reassign it)
  • has no existing pul request
  • also the issue has the label status: ready for dev

@ashutosh887
Copy link
Member

Thanks @eddiejaoude
I'll keep this in mind

@eddiejaoude
Copy link
Member

eddiejaoude commented Mar 29, 2023

PR has been merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code undefined ⭐ goal: addition undefined good first issue undefined 🔢 points: 5 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)
Projects
None yet
Development

No branches or pull requests

10 participants