Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

[BUG] Typo in the testimonials guide docs page #3514

Closed
Aadarsh805 opened this issue Jan 15, 2023 · 4 comments
Closed

[BUG] Typo in the testimonials guide docs page #3514

Aadarsh805 opened this issue Jan 15, 2023 · 4 comments
Labels

Comments

@Aadarsh805
Copy link
Member

Aadarsh805 commented Jan 15, 2023

Description

there is this typo in the Including a Testimonial on your Profile section in the testimonials guide page

If you receive a Testimonials -> If you receive a Testimonial

Group 11 (4)

How to fix

this issue can be found in the pages/docs/how-to-guides/testimonials.mdx file

The typo is right here on the 36th line in pages/docs/how-to-guides/testimonials.mdx file

image

Additional information

@eddiejaoude I also found some more typos in the testimonials written by users for your profile, which are being used as examples in the testimonials guide page, like this one:

image

which is also in your profile here
Group 13

When users write testimonials for anyone we can't guarantee that there won't be typos in that right, so maybe not fix it there on your Linkfree profile, but can have it fixed in the docs
I don't think it would even matter because it's not a part of documentation and is just an example

@Aadarsh805 Aadarsh805 added the 🛠 goal: fix undefined label Jan 15, 2023
@github-actions
Copy link
Contributor

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@Aadarsh805
Copy link
Member Author

@Pradumnasaraf this has been solved in #3510, but I still want Eddie's response on one other thing that I mentioned in the additional information
So should I close this or not

@Pradumnasaraf
Copy link
Contributor

@Pradumnasaraf this has been solved in #3510, but I still want Eddie's response on one other thing that I mentioned in the additional information So should I close this or not

You can let it remain open. You can close after Eddie's response.
Hey, @eddiejaoude can you look

@eddiejaoude
Copy link
Member

Thanks for collaborating 👍

Thanks for checking, but I think we should not update people's profiles or testimonial files even if there are typos, so we can close this issue now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants