-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to document non-API interface #3079
Comments
Here's a preview of the VS Code adapter documentation: https://staging.open-vsx.org/swagger-ui/index.html?urls.primaryName=VSCode%20Adapter |
@amvanbaren Looks good. I my scan of the logs, I also picked up some of these: |
@filiptronicek Any comments? |
@kineticsquid from https://github.com/eclipse/openvsx/blob/c317d0d3aeed94ad752b05d2539f6c4f483ed8ec/server/src/main/java/org/eclipse/openvsx/adapter/VSCodeAPI.java, I see:
|
@kineticsquid Open VSX doesn't have a |
The |
I checked the logs I have and sampled references to the My intent is to put a link to the Swagger on this wiki page: https://github.com/EclipseFdn/open-vsx.org/wiki/Compatibility-Interface. The text will read, 'The following Swagger documents the VS Marketplace interfaces implemented by Open VSX to ensure compatibility.' |
OK, link is published: https://github.com/EclipseFdn/open-vsx.org/wiki/Compatibility-Interface. I also submitted an update to point the 'Documentation' link on the menu bar to https://github.com/EclipseFdn/open-vsx.org/wiki instead of https://github.com/eclipse/openvsx/wiki. I think this makes more sense given the documentation is deployment specific. That said, the compatibility interface we just documented is not, do we want to put a pointer to the Swagger doc on https://github.com/eclipse/openvsx/wiki? |
@amvanbaren I can see my PR was merged to change the URL at the 'Docmentation' link to point to https://github.com/EclipseFdn/open-vsx.org/wiki instead of https://github.com/eclipse/openvsx/wiki. And I thought I saw it deployed. But the link still points to https://github.com/EclipseFdn/open-vsx.org/wiki. Am I missing something? |
The documentation link in the mobile menu points to https://github.com/EclipseFdn/open-vsx.org/wiki But the documentation link in the default menu doesn't. You also need to change this line: open-vsx.org/website/src/menu-content.tsx Line 185 in f59418d
|
@amvanbaren Thanks for the pointer. Here's a PR to fix that: #3164 |
For compatibility reasons, in addition to the documented API, open-vsx.org also duplicates the VS Registry Interface, e.g.,
These are some examples from our access logs. What's the best way to get a complete list of these URLs the server responds to?
The text was updated successfully, but these errors were encountered: