-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON Schemas v1.0.0 #90
base: main
Are you sure you want to change the base?
Conversation
Required GH actions failing to install dependencies. Will fix them tomorrow and re-run workflows. |
How to test that the JSON Documents are valid? In batch
If the script ends without any reported issues (i.e., the number of files with errors is 0), great news: everything inside the One by oneIf you want to validate the files one by one manually, leave the Biovalidator server open, and in the other terminal run:
Again, if the result is Be imaginativeIf you're planning on testing the validation, I would recommend to get into the JSON Documents, and randomly change something that you think should be required. If there is no error, either it wasn't as required as expected, or you found a bug 👏 |
GH actions were fixed at #91 - The only one failing is the linter. |
The SpotDescriptorType in the XSDs was confusing, having the illusion of choice that I translated to array initially, but it's an object.
Ticket reference
EEH-2630
Overall changes
Given that there are many accessory files that are modified along the schemas, I would recommend to focus on the
schemas
andjson_validation_tests
directories.For further details, see CHANGELOG. I also moved
main
todev
, until v2.0.0 schemas are released, to comply with the release documentation. This way, v1.0.0 will be released as a TAG, but also will be themain
repository, and development (of v2.0.0) will be kept within thedev
branch.Future TO-DOs and checks
meta:version
) are updated before creating the PR (see GitHub Action).tag
pointers (v1.0.0
). In other words, Biovalidator downloads automatically the JSON Schemas from this GH repo when schema-agnostic validation of the documents is done. No errors from:v1.0.0
tag fromv1.0.0
branch. Once it's been reviewed.main
, replacingv1.0.0
in both the$id$
of JSON Schemas and$ref
of JSON documents. See documentation.main
branch pointers works.