Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom LCF header parsing fails for strings with values >= 0x80 #413

Open
fdelapena opened this issue Jan 22, 2021 · 0 comments
Open

Custom LCF header parsing fails for strings with values >= 0x80 #413

fdelapena opened this issue Jan 22, 2021 · 0 comments
Labels

Comments

@fdelapena
Copy link
Contributor

The following game uses a character upper than 7-bit ASCII for a similar approach to "RM Protection Utility" (overwriting "LcfMapTree", "LcfDataBase" and "LcfMapUnit", but likely tailored to display the game name there.
This tool only uses 7-bit ASCII, so all games using this kind of "protection" are not affected.

elvespell.zip

liblcf uses ReadString to compare the value, and 0x80 and upper are affected by the ReadString BER parsing, so this game fails when doing the comparison. A possible solution would be a string comparison without ReadString.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant