Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buggy rendering for empty badges when navi is collapsed #5847

Closed
simoheinonen opened this issue Jul 19, 2023 · 1 comment · Fixed by #6678
Closed

Buggy rendering for empty badges when navi is collapsed #5847

simoheinonen opened this issue Jul 19, 2023 · 1 comment · Fixed by #6678
Labels
bug design good first issue Ideal for your first contribution! (some experience with this bundle may be required) help wanted Issues and PRs which are looking for volunteers to complete them. priority: important Bugs to fix and features to implement
Milestone
4.x

Comments

@simoheinonen
Copy link
Contributor

Describe the bug
image

To Reproduce

public function configureMenuItems(): iterable
{
    yield MenuItem::linkToCrud('Foo', 'fas fa-box-open', Foo::class)->setBadge(null);
    yield MenuItem::linkToCrud('Bar', 'fas fa-box-open', Bar::class)->setBadge(3);
}
@javiereguiluz javiereguiluz added bug help wanted Issues and PRs which are looking for volunteers to complete them. good first issue Ideal for your first contribution! (some experience with this bundle may be required) design labels Dec 31, 2024
@javiereguiluz javiereguiluz added this to the 4.x milestone Dec 31, 2024
@javiereguiluz
Copy link
Collaborator

Sorry we missed this reported issue. Will you have some time to try to fix this and send a pull request? We can help you during the process and the merging is guaranteed. Thanks!

@javiereguiluz javiereguiluz added the priority: important Bugs to fix and features to implement label Dec 31, 2024
@javiereguiluz javiereguiluz mentioned this issue Jan 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug design good first issue Ideal for your first contribution! (some experience with this bundle may be required) help wanted Issues and PRs which are looking for volunteers to complete them. priority: important Bugs to fix and features to implement
Projects
None yet
Milestone
4.x
Development

Successfully merging a pull request may close this issue.

Fix some issues with menu item badges that have no value javiereguiluz/EasyAdminBundle
2 participants
@javiereguiluz @simoheinonen