Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenlayout for Codeblock component configuration cutting off parts #830

Closed
Hefaistos68 opened this issue Dec 30, 2020 · 11 comments
Closed

Comments

@Hefaistos68
Copy link

The buttons at the bottom are cut off and only partially visible, one has to guess whats under it.
Display at 1366x768 with 100% scaling

SHFB codeblock

@EWSoftware
Copy link
Owner

I'm slowly converting everything over to WPF (#344). The property pages have been done and a few of the component configuration forms but I still need to find time to do the rest, this one included.

@EWSoftware
Copy link
Owner

It turns out, this one was converted 3 years ago in the initial set. Based on the screenshot with the raised buttons, I'd say that's the old Windows Forms version. If you're using SHFB version 2017.12.30.0 or later you'll have the newer WPF-based forms and property pages.

@Hefaistos68
Copy link
Author

Sorry to say, I have version 2020.3.6.0 installed and the screenshot is absolutely from this version.

@EWSoftware
Copy link
Owner

I tried it on my desktop and in a VM at that resolution and scaling and didn't see any clipping. It's WPF and I've never seen WPF not scale things correctly. What OS are you using? As I noted, the screen shot is showing raised buttons rather than flat style so perhaps some other system setting is affecting the layout.

@Hefaistos68
Copy link
Author

Windows 10 Home, latest updates, Asus VivoBook 15. For reference, the screenshot shows that the VS app settings show nice flat buttons, the SHFB settings dont. And that in the very same IDE and project.

image

And to avoid any version doubts:
image

@EWSoftware
Copy link
Owner

Are you perhaps not using the latest SHFB package in Visual Studio? It's version should match the SHFB tools. You might try uninstalling and reinstalling it. Have you tried it on another PC?

@EWSoftware
Copy link
Owner

I did a little more checking. Try adding the IntelliSense component and the Syntax component and open their configuration forms. Do they get clipped? I don't see any clipping but if I'm right, for you the IntelliSense one will but the Syntax Component one won't. I suspect there's something related to whether or not the overall set of controls are of a fixed height versus forms with controls that can vary in height.

@Hefaistos68
Copy link
Author

You are right, but interestingly, some dialogs have flat buttons, some not.
image
image
image

Look at the difference in window layout, depending on the selection in the left list. This difference happens for all SQL and ESENT entries.
image
image

@Hefaistos68
Copy link
Author

ok, sorry, its bad to see here. Have to put the two screen shots side by side, one is higher than the other, both lists stretch.

@EWSoftware
Copy link
Owner

The dialogs without the icon in the upper left are Windows Forms still. I think the issue with the WPF forms is that they are using a fixed height. I found a setting today that tells the form to size itself to the content so that will probably fix the issue for those. The ones with resizable content like the syntax component one must take some space away from the resizable controls so everything fits. The property page layout is flexible too. There's less text in the component description so the bottom text box shrinks a bit thus giving more space to the list boxes.

I'm not sure why the WPF property pages and dialogs aren't using the flat style on your system. On mine and in a VM I use for testing, everything uses the same flat style. I only know enough about WPF to put some basic stuff together so this sort of thing is beyond me unless I can find something that might fix it like the size to content property.

@EWSoftware
Copy link
Owner

I've applied the change that should correct this issue in the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants