Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use uppercase in convert_country lookups #2

Open
mariabnd opened this issue Dec 17, 2018 · 0 comments
Open

Use uppercase in convert_country lookups #2

mariabnd opened this issue Dec 17, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@mariabnd
Copy link
Collaborator

mariabnd commented Dec 17, 2018 •
edited
Loading

Detailed description

Make slight changes to inputs and lookups used in convert_country to avoid potential user input errors.

Context

Currently the only limitations on name input has to do with length of ISO 3166 alpha-2 inputs.

Possible implementation

Using toupper() within the function for the lookup and toTitleCase() when returning full country name
@mariabnd mariabnd added the enhancement New feature or request label Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mariabnd