-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test pypi upload fails (using legacy?) #39
Comments
probably because 0.0.1 already exists? |
#40 still has the same problem. Could be because 0.0.1 exists of course, I have no idea. |
Yes, it's probably because 0.0.1 already exists. For testpypi you can delete packages: but as far as I understand, you cannot on the official pypi. This means we need to be very careful everytime the GitHub action is called, since it will not push to pypi if there is already a version of that number |
You can yank, but you can't clobber packages (on both PyPI servers). I'll implement the normal buildnum work-around... though tbh i feel GH build artefacts are much better for this usecase. |
Ah I see, thanks for clarifying @casperdcl ; I'm still quite new to this! |
I'm a little bit lost here (of course). The TestPyPi upload CI was essentially to test if we could upload to Pypi later. My guess is that #42 serves a different purpose: people can download the very latest version from there, and presumably do some Aside from this, obviously at some point it'd be nice to upload to PyPi itself. At that point, we do need to be careful about versions, which we are not yet. It's not so clear to me if the current set-up would already be enough to upload to PyPi, or if we need other work in our CI file to make this only happen if we tag. |
Ha there's no need to test PyPI infrastructure. I'd be more worried about checking this package itself. Uploads to PyPI do already work as-is on semver tag pushes; no tokens/passwords needed. #42 does indeed allow downloading & |
ok. Feel free to merge #42. just to confirm:
|
Yes
Download & extract it to get the |
PETSIRD/.github/workflows/test_pypi.yml
Line 48 in fd6b833
Actions reports
@casperdcl @lukepolson suggestions?
The text was updated successfully, but these errors were encountered: