From 581286bfbd399765b8c8c0553138e453eca50ecd Mon Sep 17 00:00:00 2001 From: Remi Kazeroni Date: Fri, 18 Aug 2023 13:46:47 +0200 Subject: [PATCH 1/5] changed OBS maintainer in docs --- doc/sphinx/source/community/dataset.rst | 10 +++++----- doc/sphinx/source/community/review.rst | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/doc/sphinx/source/community/dataset.rst b/doc/sphinx/source/community/dataset.rst index d70438d9bc..424d4d4694 100644 --- a/doc/sphinx/source/community/dataset.rst +++ b/doc/sphinx/source/community/dataset.rst @@ -65,10 +65,10 @@ The scientific reviewer needs to check this. Data availability ================= -Once your pull request has been approved by the reviewers, ask -`@remi-kazeroni `_ +Once your pull request has been approved by the reviewers, ask a member of +`@OBS-maintainers `_ to add the new dataset to the data pool at DKRZ and CEDA-Jasmin. -He is also the person in charge of merging CMORizer pull requests. +This team is in charge of merging CMORizer pull requests. .. _dataset_checklist: @@ -165,14 +165,14 @@ Run ``esmvaltool/recipes/examples/recipe_check_obs.yml`` for new dataset. RAW data -------- -Contact person in charge of ESMValTool data pool (`@remi-kazeroni`_) and +Contact the team in charge of ESMValTool data pool (`@OBS-maintainers`_) and request to copy RAW data to RAWOBS/Tier2 (Tier3). CMORized data ------------- -Contact person in charge of ESMValTool data pool (`@remi-kazeroni`_) and +Contact the team in charge of ESMValTool data pool (`@OBS-maintainers`_) and request to * Merge the pull request diff --git a/doc/sphinx/source/community/review.rst b/doc/sphinx/source/community/review.rst index 41e596dda9..3429c0ef7a 100644 --- a/doc/sphinx/source/community/review.rst +++ b/doc/sphinx/source/community/review.rst @@ -69,7 +69,7 @@ GitHub. Pull requests are merged by the `@ESMValGroup/esmvaltool-coreteam`_. Specifically, pull requests containing a :ref:`CMORizer script` can only be merged by -`@remi-kazeroni`_, who will then add the CMORized data to the OBS data pool at +a member of `@OBS-maintainers`_, who will then add the CMORized data to the OBS data pool at DKRZ and CEDA-Jasmin. The team member who does the merge first checks that both the technical and scientific reviewer approved the pull request and that the reviews were @@ -215,7 +215,7 @@ their opinion and try to find a solution. .. _`@ESMValGroup/tech-reviewers`: https://github.com/orgs/ESMValGroup/teams/tech-reviewers .. _`@ESMValGroup/science-reviewers`: https://github.com/orgs/ESMValGroup/teams/science-reviewers .. _`@ESMValGroup/esmvaltool-coreteam`: https://github.com/orgs/ESMValGroup/teams/esmvaltool-coreteam -.. _`@remi-kazeroni`: https://github.com/remi-kazeroni +.. _`@OBS-maintainers`: https://github.com/orgs/ESMValGroup/teams/obs-maintainers .. _`pull request template`: https://raw.githubusercontent.com/ESMValGroup/ESMValTool/main/.github/pull_request_template.md .. _`Google meet`: https://meet.google.com .. _`Jitsi meet`: https://meet.jit.si From ed1dc93fdc4385e6b02b2f3a62eb96d21cd944c8 Mon Sep 17 00:00:00 2001 From: Remi Kazeroni Date: Fri, 18 Aug 2023 13:47:06 +0200 Subject: [PATCH 2/5] changed OBS codeowner --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index e1aaa42272..fad094e2f4 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,2 +1,2 @@ -esmvaltool/cmorizers @remi-kazeroni +esmvaltool/cmorizers @OBS-maintainers .github/workflows @valeriupredoi From c1bc534a33927690253878e55c039cff4c502bb4 Mon Sep 17 00:00:00 2001 From: Remi Kazeroni Date: Fri, 18 Aug 2023 13:47:26 +0200 Subject: [PATCH 3/5] added OBS item in PR template --- .github/pull_request_template.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 83cf97eb4c..65330916d4 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -62,6 +62,7 @@ It is the responsibility of the author to make sure the pull request is ready to - [ ] [๐Ÿ› ][1] [Documentation](https://docs.esmvaltool.org/en/latest/community/dataset.html#dataset-documentation) is available - [ ] [๐Ÿ› ][1] The dataset has been [added to the CMOR check recipe](https://docs.esmvaltool.org/en/latest/community/dataset.html#testing) +- [ ] [๐Ÿ› ][1] The dataset has been added to the shared [ESMValTool data pools](https://docs.esmvaltool.org/en/latest/community/dataset.html#cmorized-data) - [ ] [๐Ÿงช][2] Numbers and units of the data look [physically meaningful](https://docs.esmvaltool.org/en/latest/community/dataset.html#scientific-sanity-check) *** From 7d3b1bb305b238b59ebef4923b688366f466a48c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9mi=20Kazeroni?= Date: Fri, 18 Aug 2023 14:06:58 +0200 Subject: [PATCH 4/5] fixed codeowner --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index fad094e2f4..2086d60173 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,2 +1,2 @@ -esmvaltool/cmorizers @OBS-maintainers +esmvaltool/cmorizers @ESMValGroup/obs-maintainers .github/workflows @valeriupredoi From 71e0edf85c88ac39ded13d286e7c2e90989c9150 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9mi=20Kazeroni?= Date: Fri, 18 Aug 2023 15:04:42 +0200 Subject: [PATCH 5/5] Address review comment from @hb326 --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 65330916d4..5041b22420 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -62,7 +62,7 @@ It is the responsibility of the author to make sure the pull request is ready to - [ ] [๐Ÿ› ][1] [Documentation](https://docs.esmvaltool.org/en/latest/community/dataset.html#dataset-documentation) is available - [ ] [๐Ÿ› ][1] The dataset has been [added to the CMOR check recipe](https://docs.esmvaltool.org/en/latest/community/dataset.html#testing) -- [ ] [๐Ÿ› ][1] The dataset has been added to the shared [ESMValTool data pools](https://docs.esmvaltool.org/en/latest/community/dataset.html#cmorized-data) +- [ ] [๐Ÿ› ][1] The dataset has been added to the shared [data pools](https://docs.esmvaltool.org/en/latest/community/dataset.html#cmorized-data) of DKRZ and Jasmin by the @ESMValGroup/OBS-maintainers team - [ ] [๐Ÿงช][2] Numbers and units of the data look [physically meaningful](https://docs.esmvaltool.org/en/latest/community/dataset.html#scientific-sanity-check) ***