Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recipe_gier2020bg.yml: add sorting to SA barplot #2905

Merged
merged 6 commits into from
Nov 21, 2022
Merged

Conversation

bettina-gier
Copy link
Contributor

@bettina-gier bettina-gier commented Nov 2, 2022

Following @bouweandela's request, I added sorting and correct labels on the barplot in recipe_gier2020bg.yml so it will pass the automated testing without manual checks due to random sorting.

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic

@bettina-gier
Copy link
Contributor Author

Failing readthedocs build seems to be on @schlunma parts "Failed to import esmvaltool.diag_scripts.mlr.models.gbr_xgboost."

At least this pull request changes no doc files ;)

@schlunma
Copy link
Contributor

schlunma commented Nov 2, 2022

Not my fault 😉 #2903

@bettina-gier
Copy link
Contributor Author

Learning to read would help me, thanks ^__^

@bouweandela
Copy link
Member

@esmvalbot Please run recipe_gier2020bg.yml

@esmvalbot
Copy link

esmvalbot bot commented Nov 3, 2022

Since @bouweandela asked, ESMValBot will run recipe recipe_gier2020bg.yml as soon as possible, output will be generated here

@esmvalbot
Copy link

esmvalbot bot commented Nov 3, 2022

ESMValBot is sorry to report it failed to run recipe recipe_gier2020bg.yml: exit is 1, output has been generated here

@zklaus
Copy link

zklaus commented Nov 3, 2022

The conda-forge issue re xgboost is fixed (conda-forge/xgboost-feedstock#104). I'll trigger the ci bi closing and reopening.

@zklaus zklaus closed this Nov 3, 2022
@zklaus zklaus reopened this Nov 3, 2022
@bouweandela
Copy link
Member

bouweandela commented Nov 3, 2022

@remi-kazeroni Is there a reason why the permissions of /work/bd0854/DATA/ESMValTool2/OBS/Tier3 and /work/bd0854/DATA/ESMValTool2/download on Levante are set such that 'other' has no access? This prevents the esmvalbot from accessing the data.

@remi-kazeroni
Copy link
Contributor

@remi-kazeroni Is there a reason why the permissions of /work/bd0854/DATA/ESMValTool2/OBS/Tier3 and /work/bd0854/DATA/ESMValTool2/download on Levante are set such that 'other' has no access? This prevents the esmvalbot from accessing the data.

Yes, the Tier3 directory is not open to non-ESMValTool developers due to the long-standing license issues that were discussed at the workshop. The download directory is our (ESMValTool devs) pool of CMIP data that were downloaded because missing from the "official" data pool on Levante. I think it is preferable not to give access to all Levante users as this data pool may contain outdated or retracted data and we can't afford to maintain it.
Instead of opening these directory to "others", would it be possible to add the esmvalbot to the bd0854 group?

@bouweandela
Copy link
Member

Unfortunately not, because this is not an account that exists on Levante, it is local to the esmvaltool vm.

@bettina-gier
Copy link
Contributor Author

Maybe we should make a separate issue for using the esmvalbot with Tier 3 data - Is this really the first time this problem is encountered? With ERA-Interim and ERA5 being Tier 3 I would've thought more recipes would encounter this issue.

For this review - maybe run it manually? Or I can run it again and upload the results before it gets swallowed in nirvana ;)

@remi-kazeroni
Copy link
Contributor

For this review - maybe run it manually? Or I can run it again and upload the results before it gets swallowed in nirvana ;)

If you point me to a recipe run on Levante, I can copy the data to the VM and generate a webpage to display the results that would be used to review the PR. Let's see when Levante is back 😄

@bouweandela
Copy link
Member

Is this really the first time this problem is encountered?

Yes, as far as I'm aware at least. It used to work just fine.

@bettina-gier
Copy link
Contributor Author

For this review - maybe run it manually? Or I can run it again and upload the results before it gets swallowed in nirvana ;)

If you point me to a recipe run on Levante, I can copy the data to the VM and generate a webpage to display the results that would be used to review the PR. Let's see when Levante is back smile

Here you go Remi:
/work/bd0854/b309137/esmval/output/recipe_gier2020bg_20221115_092443

@remi-kazeroni
Copy link
Contributor

remi-kazeroni commented Nov 15, 2022

Here you go Remi:
/work/bd0854/b309137/esmval/output/recipe_gier2020bg_20221115_092443

Thanks @bettina-gier! The webpage for this recipe run can be found here. In particular, the plots are here.

edit: I didn't upload the preproc dir to save space on the VM

@bettina-gier
Copy link
Contributor Author

Thanks Remi!

With this I can easily make the review even easier ;)
The changed plot is :
compared to the old (from the release testing):

@schlunma schlunma added this to the v2.8.0 milestone Nov 21, 2022
Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and output look good to me, thanks! 🚀

@bouweandela bouweandela merged commit d72263e into main Nov 21, 2022
@bouweandela bouweandela deleted the revise_gier2020bg branch November 21, 2022 10:37
@bouweandela
Copy link
Member

Thanks @bettina-gier and @schlunma!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants