-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recipe_gier2020bg.yml: add sorting to SA barplot #2905
Conversation
Failing readthedocs build seems to be on @schlunma parts "Failed to import esmvaltool.diag_scripts.mlr.models.gbr_xgboost." At least this pull request changes no doc files ;) |
Not my fault 😉 #2903 |
Learning to read would help me, thanks ^__^ |
@esmvalbot Please run recipe_gier2020bg.yml |
Since @bouweandela asked, ESMValBot will run recipe recipe_gier2020bg.yml as soon as possible, output will be generated here |
ESMValBot is sorry to report it failed to run recipe recipe_gier2020bg.yml: exit is 1, output has been generated here |
The conda-forge issue re xgboost is fixed (conda-forge/xgboost-feedstock#104). I'll trigger the ci bi closing and reopening. |
@remi-kazeroni Is there a reason why the permissions of |
Yes, the |
Unfortunately not, because this is not an account that exists on Levante, it is local to the esmvaltool vm. |
Maybe we should make a separate issue for using the esmvalbot with Tier 3 data - Is this really the first time this problem is encountered? With ERA-Interim and ERA5 being Tier 3 I would've thought more recipes would encounter this issue. For this review - maybe run it manually? Or I can run it again and upload the results before it gets swallowed in nirvana ;) |
If you point me to a recipe run on Levante, I can copy the data to the VM and generate a webpage to display the results that would be used to review the PR. Let's see when Levante is back 😄 |
Yes, as far as I'm aware at least. It used to work just fine. |
Here you go Remi: |
Thanks @bettina-gier! The webpage for this recipe run can be found here. In particular, the plots are here. edit: I didn't upload the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and output look good to me, thanks! 🚀
Thanks @bettina-gier and @schlunma! |
Following @bouweandela's request, I added sorting and correct labels on the barplot in recipe_gier2020bg.yml so it will pass the automated testing without manual checks due to random sorting.
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated recipe/diagnostic
l#scientific-sanity-check)