-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instructions to support the cmorization of several versions of a dataset #2341
Comments
Great idea! I suggest getting #1657 in first, but after that, this will be a very nice addition! |
This is rather independent from #1657. The documentation I plan to add would be marginally affected by #1657. I agree finishing #1657 is high priority but it is too big to be merged shortly before a release and should rather be merged after a release to allow ample testing by the community as I wrote in my review. |
Completely agree with everything you said. It's just a matter of where to invest the available time and #1657 must get in asap. |
@remi-kazeroni Release v2.5 is approaching quickly (the feature freeze will be on 2022-02-21). Since this issue is marked for v2.5, could you briefly comment if you further intend to include this in the new release and/or if you are facing any problems with it? Thanks!! |
Let's keep the milestone a bit. I'm not sure I'll have the time to take care of this documentation for the release. If not that will be in v2.6. |
Any chance this can make it to 2.6? There isn't any PR open. |
I wanted to work on that soon but I'd rather not delay the release for this. |
Is your feature request related to a problem? Please describe.
When a cmorizer script is updated to account for a newer version of a dataset, the cmorization of the previous version is usually no longer possible because the code and information are deleted (access to source files, cmorization script, options, ...). We discussed some time ago that we would prefer to extend cmorizers to support a newer data version rather than deleting the previous cmorizer. This would ensure reproducibility and ease comparison of results. We could support the cmorization several versions of a dataset as long as the data are available. This may also help in some cases when updating recipes with the newest version of a dataset is not straightforward.
To this end, we need to update our instructions to explain how to handle best several versions of a cmorizers. My suggestion to support
dataset_v1
anddataset_v2
would be:version
key defined in the config file (version: v1
orversion v2
). To cmorize one or the other version of the data, one could simply comment and uncomment the relevant parts of the config file.Would you be able to help out?
Would you have the time and skills to implement the solution yourself? Yes, I'm planning to do so.
The text was updated successfully, but these errors were encountered: