Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix units and valid_range of AIRS-2-0 #2465

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Fix units and valid_range of AIRS-2-0 #2465

merged 2 commits into from
Jun 26, 2024

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Jun 26, 2024

Description

Fixes ESMValGroup/ESMValTool#3680


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added the fix for dataset Related to dataset-specific fix files label Jun 26, 2024
@schlunma schlunma added this to the v2.11.0 milestone Jun 26, 2024
@schlunma schlunma requested review from ehogan and valeriupredoi June 26, 2024 09:31
@schlunma schlunma self-assigned this Jun 26, 2024
@schlunma schlunma changed the title Fix units and valid_range of AIRS-2-0 Fix units and valid_range of AIRS-2-0 Jun 26, 2024
@schlunma
Copy link
Contributor Author

The two recipes mentioned in ESMValGroup/ESMValTool#3680 look fine with this change 🎉

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.62%. Comparing base (f2496b6) to head (5d7c05c).
Report is 32 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2465   +/-   ##
=======================================
  Coverage   94.62%   94.62%           
=======================================
  Files         246      247    +1     
  Lines       14055    14065   +10     
=======================================
+ Hits        13299    13309   +10     
  Misses        756      756           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, cheers, Manu! Maybe we should also make sure im the future data doesn't get in with a valid_max and/or valid_min, if they change the data output (if there's a valid_range that means there are no _min and _max, but they can change from a range to min/max) - of course we can do this at a later stage and not here now 👍🍺

@schlunma
Copy link
Contributor Author

schlunma commented Jun 26, 2024

Thanks V! Let's adapt the fix if we need it. The file has not changed since 2019, so I guess we should be fine for some time 😁

@schlunma schlunma merged commit b8bcbec into main Jun 26, 2024
6 checks passed
@schlunma schlunma deleted the fix_airs branch June 26, 2024 11:53
@valeriupredoi
Copy link
Contributor

Thanks V! Let's adapt the fix if we need it. The file has not changed since 2019, so I guess we should be fine for some time 😁

Plan, Batman 🦇

ehogan pushed a commit that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix for dataset Related to dataset-specific fix files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Results of Su et al. (2014) emergent constraints are wrong
2 participants