-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix units and valid_range
of AIRS-2-0
#2465
Conversation
valid_range
of AIRS-2-0
The two recipes mentioned in ESMValGroup/ESMValTool#3680 look fine with this change 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2465 +/- ##
=======================================
Coverage 94.62% 94.62%
=======================================
Files 246 247 +1
Lines 14055 14065 +10
=======================================
+ Hits 13299 13309 +10
Misses 756 756 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, cheers, Manu! Maybe we should also make sure im the future data doesn't get in with a valid_max and/or valid_min, if they change the data output (if there's a valid_range that means there are no _min and _max, but they can change from a range to min/max) - of course we can do this at a later stage and not here now 👍🍺
Thanks V! Let's adapt the fix if we need it. The file has not changed since 2019, so I guess we should be fine for some time 😁 |
Plan, Batman 🦇 |
Description
Fixes ESMValGroup/ESMValTool#3680
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: