Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve cube attribute global vs local when concatenating #2449

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Jun 6, 2024

Description

Preserve cube attribute global vs local as well as possible in esmvalcore.preprocessor.concatenate. See iris.cube.CubeAttrsDict for more information.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.62%. Comparing base (1da5bbc) to head (8262ec2).
Report is 33 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2449   +/-   ##
=======================================
  Coverage   94.61%   94.62%           
=======================================
  Files         246      246           
  Lines       14048    14055    +7     
=======================================
+ Hits        13292    13299    +7     
  Misses        756      756           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bouweandela bouweandela requested a review from schlunma June 6, 2024 12:33
@bouweandela bouweandela marked this pull request as ready for review June 6, 2024 12:33
@bouweandela bouweandela added the bug Something isn't working label Jun 6, 2024
@bouweandela bouweandela requested a review from katjaweigel June 6, 2024 12:37
@katjaweigel
Copy link
Contributor

Looks good, thanks!
A short test version of recipe_martin18grl.yml (renamed because git does not like yml) runs with this branch of the core but not with v2.11.x
recipe_martin18grl_yml_test.txt

@bouweandela
Copy link
Member Author

bouweandela commented Jun 6, 2024

@ehogan @chrisbillowsMO It might be nice to include this in the v2.11 release if possible.

Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bouwe, looks good to me!

@bouweandela bouweandela merged commit ee16a95 into main Jun 7, 2024
6 checks passed
@bouweandela bouweandela deleted the preserve-attribute-global-local branch June 7, 2024 11:31
@chrisbillowsMO
Copy link
Contributor

@ehogan @chrisbillowsMO It might be nice to include this in the v2.11 release if possible.

Nice is our speciality! Cherry picked in here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants