-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interpolate
to resample_hours
#2440
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2440 +/- ##
=======================================
Coverage 94.51% 94.51%
=======================================
Files 246 246
Lines 14024 14027 +3
=======================================
+ Hits 13255 13258 +3
Misses 769 769 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests with the diurnal cycle diagnostic were successful, the results look good. The documentation also looks fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks Manu and Axel! Code review fine by me, but with a few very minor observations 🍺
Co-authored-by: Valeriu Predoi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
many thanks for the changes, Manu! This is RtM 🍺
Description
Add interpolation capabilities to
resample_hours
.Closes #2439
Link to documentation: https://esmvaltool--2440.org.readthedocs.build/projects/ESMValCore/en/2440/recipe/preprocessor.html#resample-hours
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: