Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interpolate to resample_hours #2440

Merged
merged 8 commits into from
Jun 5, 2024
Merged

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented May 28, 2024

Description

Add interpolation capabilities to resample_hours.

Closes #2439

Link to documentation: https://esmvaltool--2440.org.readthedocs.build/projects/ESMValCore/en/2440/recipe/preprocessor.html#resample-hours


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added the preprocessor Related to the preprocessor label May 28, 2024
@schlunma schlunma added this to the v2.12.0 milestone May 28, 2024
@schlunma schlunma self-assigned this May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.51%. Comparing base (4053008) to head (81e7d74).
Report is 38 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2440   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files         246      246           
  Lines       14024    14027    +3     
=======================================
+ Hits        13255    13258    +3     
  Misses        769      769           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@axel-lauer axel-lauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests with the diurnal cycle diagnostic were successful, the results look good. The documentation also looks fine.

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Manu and Axel! Code review fine by me, but with a few very minor observations 🍺

doc/recipe/preprocessor.rst Outdated Show resolved Hide resolved
doc/recipe/preprocessor.rst Outdated Show resolved Hide resolved
esmvalcore/preprocessor/_time.py Show resolved Hide resolved
esmvalcore/preprocessor/_time.py Show resolved Hide resolved
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks for the changes, Manu! This is RtM 🍺

@valeriupredoi valeriupredoi merged commit 1da5bbc into main Jun 5, 2024
6 checks passed
@valeriupredoi valeriupredoi deleted the interpolate_resample_hours branch June 5, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preprocessor Related to the preprocessor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interpolation in resample_hours
4 participants