-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove compilers dependency from conda environment and force install x64 git in OSX Github Action workflows #2420
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2420 +/- ##
=======================================
Coverage 94.51% 94.51%
=======================================
Files 246 246
Lines 14023 14023
=======================================
Hits 13254 13254
Misses 769 769 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me @valeriupredoi, could you clean up a bit?
The compilers package was needed a long time ago, when we were still installing most packages from PyPI and only those that weren't on PyPI from conda.
Thanky, bud 🍺 |
Description
Closes #2419
compilers
was added by @bouweandela four years ago in #603 - see #603 (comment) - I don't think we still need it but may be worth checking the docker build goes well without it anywayOSX tests: failing with "setuptools_scm._run_cmd.CommandNotFoundError: git" - this has been seen in ESMValGroup/ESMValTool#3581 and it's not hitting just this node, but rather, it's an endemic issue related to macOS 14 on arm64:
For some reason, the system git goes fishing when the x64 environment is activated and used - @schlunma and I had a decent debate about it in the linked Tool PR - no time to really-really understand the issue, just plop a git installer in the workflow!
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: