Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Python to lower than 3.12 #2272

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Pin Python to lower than 3.12 #2272

merged 1 commit into from
Dec 7, 2023

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Dec 7, 2023

Description

Temporarily pin Python to lower than 3.12 until the issue with prospector/flake8 is resolved. See #2228 (comment).

Once this is merged and the new docker container is built, it should fix the failing tests on CircleCI for now.

Closes #2271


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@bouweandela bouweandela marked this pull request as ready for review December 7, 2023 08:03
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, bud! Honestly, since we don't use actively use prospector in any tests, I'd have commented out that dependency, but this is clearer and in line with our installation procedure. We may have to do the same in the conda recipe at release point next week

@bouweandela bouweandela merged commit c170325 into main Dec 7, 2023
2 of 3 checks passed
@bouweandela bouweandela deleted the pin-python-lower-3.12 branch December 7, 2023 12:50
bouweandela added a commit that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants