Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-model statistics produces wrong/misleading results for daily data #937

Closed
Peter9192 opened this issue Jan 12, 2021 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@Peter9192
Copy link
Contributor

Peter9192 commented Jan 12, 2021

Describe the bug
The current implementation of the multimodel statistics preprocessor was not designed to work for daily data, but it doesn't raise an error either. This leads to misleading results, because prior to the statistics calculations, all time points are reset to the first of the month:

real_date = datetime(date_obj.year, date_obj.month, 1, 0, 0, 0)

This error has propagated into the reference datasets for the multimodel-statistics regression tests. While the sample data have 62 time points (days), the reference statistics cubes only have 2 (the first days of the 2 months).

This issue will be solved in #685, but until then, daily multimodel-statistics output should not be trusted.

@bouweandela
Copy link
Member

@Peter9192 Can this issue be closed, now that #685 was merged?

@Peter9192
Copy link
Contributor Author

Yes, thanks! I wanted to add automation but I forgot...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants