Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding area weighted RMS to area_statistics #739

Closed
pepcos opened this issue Aug 5, 2020 · 4 comments · Fixed by #747
Closed

Adding area weighted RMS to area_statistics #739

pepcos opened this issue Aug 5, 2020 · 4 comments · Fixed by #747
Labels
enhancement New feature or request preprocessor Related to the preprocessor

Comments

@pepcos
Copy link
Contributor

pepcos commented Aug 5, 2020

Would it be possible to add the iris analysis operator Root Mean Square (with area weighting) to the area_statistics function?
My guess is that just adding it to theoperators array in the get_iris_analysis_operation function should solve it.
@pepcos pepcos added the enhancement New feature or request label Aug 5, 2020
@bouweandela bouweandela added the preprocessor Related to the preprocessor label Aug 7, 2020
@bouweandela
Copy link
Member

Would it be possible to add the iris analysis operator Root Mean Square (with area weighting) to the area_statistics function?

Yes, I think so. Would you be able and willing to implement this and make a pull request? Let me know if you need help.

@pepcos
Copy link
Contributor Author

pepcos commented Aug 12, 2020

Yes, thanks @bouweandela! I'll create the pertinent pull request.

@pepcos
Copy link
Contributor Author

pepcos commented Aug 12, 2020

The enhancement is ready to be pushed to a new branch but I don't have permission to ESMValGroup/ESMValCore.git. Would you be able to grant me access?

Thanks

@bouweandela
Copy link
Member

The enhancement is ready to be pushed

Great!

Would you be able to grant me access?

I believe everyone who is able to do that is on holiday at the moment. Maybe it would be easiest if you could fork the repository and make the pull request from there. Would you be able to do that?

@pepcos pepcos mentioned this issue Aug 12, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request preprocessor Related to the preprocessor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add RMS iris analysis operator to statistics preprocessor functions pepcos/ESMValCore
2 participants
@bouweandela @pepcos