-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How should multi-model statistics work for a single cube? #1211
Comments
The result for |
I would prefer a refusal to compute, because trying to compute a multimodel statistic on a single model probably means that there is a mistake in the recipe. |
I also think refusing to compute makes sense. @remi-kazeroni, @katjaweigel I think you guys stumbled over this recently. What do you think? |
There seem to be no opposing views, so we'll keep the current behavior. |
I'd like to re-open this discussion. I think multi-model statistics should work for single cubes. My main arguments are:
|
@ESMValGroup/esmvaltool-coreteam any opinions on that? |
I agree with that. From a user perspective, it would be great if the multi-model statistics could handle single elements. |
I just realized that I already opened another issue for that back in February since I didn't search for closed issues 😄 I will close that one and continue the discussion here. |
That sounds like a good reason to allow it for ensemble_statistics. |
Yes, but since ESMValCore/esmvalcore/preprocessor/_multimodel.py Lines 522 to 566 in 96419a7
|
Would it make sense to log a warning when multimodel stats is called on a single cube? Then we make an effort to alert users and have them think twice, without completely blocking their flow. |
ah but how did I manage to miss this exciting discussion 😁 Thanks for re-opening the discussion, Manu! I'd go a bit more extremo than what @Peter9192 suggests and ask for a check if |
Is all that babysitting necessary? A set with one member is well defined as are the summary statistics for it. IMHO there should at most be a warning that a trivial operation is conducted if that at all and be done with it. |
I kinda disagree here. From a mathematical point of view, most of these operations are well-defined for single cubes. For example, the arithmetic mean makes perfectly sense for |
Yes, fully agree here! |
Perfect, thanks V!! 🍻 |
The new multi-model statistics code refuses to calculate statistics on a single model.
That is one approach to things, but for most statistics it's perfectly possible to compute them on a single cube as well, albeit perhaps not super useful.
To me, it seems the two alternatives here are
What do you prefer, @ESMValGroup/esmvaltool-developmentteam ?
The text was updated successfully, but these errors were encountered: