-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Circle test picks up release package installed from conda and not current branch esmvalcore #1063
Comments
Why do you think this is the case? The ESMValCore/.circleci/config.yml Lines 33 to 36 in c0cc45f
. Nowhere in these steps is there any mention of the esmvalcore conda package.
|
@bouweandela here's yer proof: GA test run in development on the branch using the actual branch codebase (doesn't fail, as I'd expect it) vs Circle test that's failing because it is using either master or release codebase (I think it's the release since look where it picks up esmvalcore from: |
It gets installed there because this command ESMValCore/.circleci/config.yml Line 35 in c0cc45f
does not contain -e .
That seems unlikely, installing the Lines 211 to 213 in c0cc45f
that shouldn't change the test results. |
Does the container need refreshing then? Bouwe, this is a rather serious issue, something that we need to get to the bottom of, otherwise we risk introducing bugs that get uncovered only after merging into |
The docker container is just 4 days old, you can see it on dockerhub. It will be rebuilt from |
OK so indeed, installing it with pip does not pick up the release but rather some current branch, but this test keeps failing where it should not fail if the test is run with the current development branch, is it because |
the mystery related to this issue is solved by figuring out #1159 - a problem that's got its own isue, so closing this, my apologies for doubting the sanity of your test container @bouweandela 😁 |
The Circle test runs with the esmvalcore installed from conda at env creation point and is not overwritten by the package from the current branch under testing. This is not the desired behavior since
pip install -e .[test]
does not replace the conda install with the local pip installThe text was updated successfully, but these errors were encountered: