Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

num_nodes should work as an argument in config_batch.xml #4189

Open
jgfouca opened this issue Mar 8, 2022 · 9 comments
Open

num_nodes should work as an argument in config_batch.xml #4189

jgfouca opened this issue Mar 8, 2022 · 9 comments
Assignees

Comments

@jgfouca
Copy link
Contributor

jgfouca commented Mar 8, 2022

{{ num_nodes }} works when used in a directive, but not as an argument.

<directive                       > -nnodes {{ num_nodes }} </directive>

^ Works

<arg flag="-n" name="{{ num_nodes }}"/> # $NUM_NODES also does not work

^ Broken

I'm not sure why we'd support syntax and parameters for directives but not arguments.

@jgfouca jgfouca self-assigned this Mar 8, 2022
@jedwards4b
Copy link
Contributor

Where is this located? In config_machines I see things like: -c {{ srun_binding }} that work fine. Why is the syntax of <submit_args> in config_batch.xml like it is? It seems like it would be better if it used the same syntax as config_machines.xml (I think that because name is an attribute and not a text section it is not parsed.)

@jgfouca
Copy link
Contributor Author

jgfouca commented Mar 9, 2022

@jedwards4b , this is something I tried to do in config_batch.xml and it was much harder than I expected.

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label May 3, 2023
@jgfouca jgfouca removed the Stale label May 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jun 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

This issue was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 8, 2023
@ekluzek ekluzek removed the Stale label Jun 8, 2023
@ekluzek
Copy link
Contributor

ekluzek commented Jun 8, 2023

This was closed by the Stale-bot, but looks like we don't want it closed, so reopening.

@ekluzek ekluzek reopened this Jun 8, 2023
@jgfouca
Copy link
Contributor Author

jgfouca commented Jun 8, 2023

@ekluzek , yes, we still want this.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Sep 7, 2023
@jgfouca jgfouca removed the Stale label Sep 7, 2023
Copy link
Contributor

github-actions bot commented Dec 7, 2023

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants