Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up "mpas15-3" grid entries #153

Closed
adamrher opened this issue Feb 29, 2024 · 6 comments · Fixed by #158 or #165
Closed

clean up "mpas15-3" grid entries #153

adamrher opened this issue Feb 29, 2024 · 6 comments · Fixed by #158 or #165
Assignees
Labels
bug Something isn't working

Comments

@adamrher
Copy link
Contributor

adamrher commented Feb 29, 2024

@slevis-lmwg notes:

When I type git grep mpasa15-3 in /ccs_config, I get:

component_grids_nuopc.xml:  <domain name="mpasa15-3conus">
component_grids_nuopc.xml:    <mesh driver="nuopc">$DIN_LOC_ROOT/share/meshes/mpasa15-3.conus_ESMF_desc.210816.nc</mesh>
modelgrid_aliases_mct.xml:  <model_grid alias="mpasa15-3_mpasa15-3" not_compset="_POP">
modelgrid_aliases_mct.xml:    <grid name="atm">mpasa15-3</grid>
modelgrid_aliases_mct.xml:    <grid name="lnd">mpasa15-3</grid>
modelgrid_aliases_mct.xml:    <grid name="ocnice">mpasa15-3</grid>
modelgrid_aliases_nuopc.xml:  <model_grid alias="mpasa15-3_mpasa15-3" not_compset="_POP">
modelgrid_aliases_nuopc.xml:    <grid name="atm">mpasa15-3</grid>
modelgrid_aliases_nuopc.xml:    <grid name="lnd">mpasa15-3</grid>
modelgrid_aliases_nuopc.xml:    <grid name="ocnice">mpasa15-3</grid>
modelgrid_aliases_nuopc.xml:  <model_grid alias="mpasa15-3-conus_mpasa15-3-conus" not_compset="_POP">
modelgrid_aliases_nuopc.xml:    <grid name="atm">mpasa15-3</grid>
modelgrid_aliases_nuopc.xml:    <grid name="lnd">mpasa15-3</grid>
modelgrid_aliases_nuopc.xml:    <grid name="ocnice">mpasa15-3</grid>```

In my copy of component_grids_nuopc.xml I removed "conus" from the name to get things to work. If we prefer a different fix, I'm open to that.

I responded

Ah, I see. So the problem is that the grid aliases are referencing "mpasa15-3" but it doesn't actually exist in component_grids_nuopc.xml. So we need to clean up moodelgrid_aliases_xxx to only reference "mpasa15-3conus". And it looks like a duplicate grid alias in nuopc.

This mpasa15-3conus grid is not installed in any other externals. I checked with Bill Skamarock and he said the origins of this partial grid install occurred during a time when we were more aspirational in getting these big grids running in CESM. This grid is not runnable at present, but maybe it might be in the future so I'd just recommend fixing the inconsistencies and not removing mpasa15-3conus altogether.

@PeterHjortLauritzen @ekluzek

@adamrher adamrher added the bug Something isn't working label Feb 29, 2024
@adamrher adamrher changed the title clean "mpas15-3" grid entries clean up "mpas15-3" grid entries Feb 29, 2024
@ekluzek
Copy link
Contributor

ekluzek commented Feb 29, 2024

Wait @adamrher I'm not clear what you are suggesting. Sam's suggestion was to change mpas15-3conus to mpas15-3. I think the way to go is to change mpas15-3 to mpas15-3conus. Either way should work, but it has impact on how models will refer to the grid. I'm thinking we need to do the later so only mpas15-3conus is used. Do you agree with that?

@adamrher
Copy link
Contributor Author

Yes, I agree. I guess I wasn't clear on that point.

@ekluzek
Copy link
Contributor

ekluzek commented Feb 29, 2024

The other thing I should have asked is who is going to do this? I'm assuming you will. And once it's done you'll let us know we'll integrate into both CAM and CTSM. Does that sound right?

@adamrher adamrher self-assigned this Feb 29, 2024
@adamrher
Copy link
Contributor Author

Yeah I can do a PR that fixes this and #152.

What is to "integrate into both CAM and CTSM" ? We are not supporting this grid in CESM3.0, and neither mpasa15-3 nor mpasa15-3conus are referenced anywhere in CAM. Are they referenced in CTSM anywhere?

@ekluzek
Copy link
Contributor

ekluzek commented Feb 29, 2024

Oh, I was going to say it's in the Grids file. But, now I notice it has a question mark...

mpasa15-3conus?

So this is just something that needs to happen post CESM3. That helps to know. Thanks...

@adamrher
Copy link
Contributor Author

Yep. There is no X in the "Install in CESM3" column for 15-3conus grid.

But there is a X? for uniform 15 km ... that's my next task to figure out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants