Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some answer changes for release branch #841

Merged
merged 9 commits into from
Nov 19, 2019

Conversation

ekluzek
Copy link
Collaborator

@ekluzek ekluzek commented Nov 15, 2019

Description of changes

answer changes needed. Move prescribed soil moisture dataset being used.

For soil moisture streams apply over both nat-veg and crop.

This is answer changing.

Point to $CSMDATA/lnd/clm2/prescribed_data/LFMIP-pdLC-SST.H2OSOI.0.9x1.25.20levsoi.natveg.1980-2014.MONS_climo.c190716.nc

Specific notes

Contributors other than yourself, if any:

CTSM Issues Fixed (include github issue #): #175, #817, #832 #833

Fixes #817 -- Have clm4_5 use the same ndep file as clm5_0 for 1850
Fixes #175 -- Have clm4_5 use the same settings for urbantv years as clm5_0
Fixes #832 -- don't override with missing value, let the model set it
Fixes #833 -- time interpolation of soilm causes bad values for some missing points

Are answers expected to change (and if so in what way)? Yes!

prescribed soil moisture changes, so that grid points that are missing on the input dataset, just run CLM normally, time interpolation might show that more points are missing, and prescribed soil moisture is also done for crops.

For clm4_5, the same ndep file is used for 1850 as for clm5_0, and same settings for urbantv are now used as well (rather than present day).

Any User Interface Changes (namelist or namelist defaults changes)? Yes namelist defaults

clm4_5 defaults for ndep and urbantv years mirror clm5_0

Testing performed, if any: regular, running standard testing on cheyenne and izumi

…ulations and has time-stamps at the mid-point of the month
…the input soilm dataset, cycle so that the data isn't modified and CTSM just runs for that point, rather than doing a strange modification to it by using the missing value data from the file, also if h2osoi_vol_prs is large set to spval rather than using it, these two changes resolve: ESCOMP#832 ESCOMP#833
@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete branch tag: release Changes go on release branch as well as master labels Nov 15, 2019
@ekluzek ekluzek added this to the cesm2.1.2 milestone Nov 15, 2019
@ekluzek ekluzek self-assigned this Nov 15, 2019
@ekluzek
Copy link
Collaborator Author

ekluzek commented Nov 19, 2019

Testing has gone as expected. Here are the tests that show different answers from release-clm5.0.28:

SMS.f10_f10_musgs.I2000Clm50BgcCrop.izumi_pgi.clm-crop
SMS_D.f10_f10_musgs.I2000Clm50BgcCrop.izumi_pgi.clm-crop
SMS_D_Ld1.f19_g17.I1850Clm45Cn.izumi_gnu.clm-default
SMS_D_Ld5.f10_f10_musgs.I1850Clm45BgcCrop.izumi_nag.clm-crop
ERI_D_Ld9.f09_g16.I1850Clm45BgcCruGs.cheyenne_intel.clm-default
ERP_D_Ld3.f09_g17.I2000Clm50SpGs.cheyenne_intel.clm-prescribed
ERP_D_Ld5.f10_f10_musgs.IHistClm45SpGs.cheyenne_intel.clm-decStart
ERP_P36x2_D_Ld5.f09_g17.I2000Clm45Sp.cheyenne_gnu.clm-prescribed
ERP_P36x2_D_Ld5.f09_g17.I2000Clm45Sp.cheyenne_intel.clm-prescribed
ERP_P36x2_D_Ld5.f10_f10_musgs.I1850Clm45BgcCrop.cheyenne_intel.clm-crop
ERP_P36x2_D_Ld5.f10_f10_musgs.I1850Clm45BgcCru.cheyenne_intel.clm-default
ERP_P36x2_D_Ld5.f10_f10_musgs.I1850Clm45Cn.cheyenne_intel.clm-default
ERP_P36x2_D_Ld5.f10_f10_musgs.IHistClm45BgcCruGs.cheyenne_intel.clm-decStart
ERS_Ly5_P72x1.f10_f10_musgs.IHistClm45BgcCrop.cheyenne_intel.clm-cropMonthOutput
SMS_Ld5.f10_f10_musgs.I1850Clm45BgcCrop.cheyenne_gnu.clm-crop
SMS_Ld5.f10_f10_musgs.I1850Clm45BgcCrop.cheyenne_intel.clm-crop

@ekluzek ekluzek merged commit c089c8a into ESCOMP:release-clm5.0 Nov 19, 2019
@ekluzek ekluzek deleted the relanswerchangesfor5029 branch November 19, 2019 19:16
AGonzalezNicolas pushed a commit to HPSCTerrSys/clm5_0 that referenced this pull request Jun 27, 2024
AGonzalezNicolas pushed a commit to HPSCTerrSys/clm5_0 that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch tag: release Changes go on release branch as well as master enhancement new capability or improved behavior of existing capability PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant