From 1474f2a4a3b75d41febf7c848e8a756d8a262443 Mon Sep 17 00:00:00 2001 From: Gregory Lemieux Date: Mon, 22 May 2023 11:01:25 -0700 Subject: [PATCH 1/3] update fates history tests to use double precision --- cime_config/testdefs/testmods_dirs/clm/Fates/user_nl_clm | 1 + .../testdefs/testmods_dirs/clm/FatesColdAllVars/user_nl_clm | 1 + cime_config/usermods_dirs/fates_sp/user_nl_clm | 1 + 3 files changed, 3 insertions(+) diff --git a/cime_config/testdefs/testmods_dirs/clm/Fates/user_nl_clm b/cime_config/testdefs/testmods_dirs/clm/Fates/user_nl_clm index 2a915f2fd7..c27e69b531 100644 --- a/cime_config/testdefs/testmods_dirs/clm/Fates/user_nl_clm +++ b/cime_config/testdefs/testmods_dirs/clm/Fates/user_nl_clm @@ -2,6 +2,7 @@ hist_mfilt = 365 hist_nhtfrq = -24 hist_empty_htapes = .true. +hist_ndens = 1 fates_spitfire_mode = 1 hist_fincl1 = 'FATES_NCOHORTS', 'FATES_TRIMMING', 'FATES_AREA_PLANTS', 'FATES_AREA_TREES', 'FATES_COLD_STATUS', 'FATES_DROUGHT_STATUS', 'FATES_GDD', diff --git a/cime_config/testdefs/testmods_dirs/clm/FatesColdAllVars/user_nl_clm b/cime_config/testdefs/testmods_dirs/clm/FatesColdAllVars/user_nl_clm index 0a0726dcce..85f54fa214 100644 --- a/cime_config/testdefs/testmods_dirs/clm/FatesColdAllVars/user_nl_clm +++ b/cime_config/testdefs/testmods_dirs/clm/FatesColdAllVars/user_nl_clm @@ -3,6 +3,7 @@ hist_mfilt = 365 hist_nhtfrq = -24 hist_empty_htapes = .false. fates_spitfire_mode = 1 +hist_ndens = 1 hist_fincl1 = 'FATES_CROWNAREA_PF', 'FATES_CANOPYCROWNAREA_PF', 'FATES_NCL_AP', 'FATES_NPATCH_AP', 'FATES_VEGC_AP', 'FATES_SECONDARY_FOREST_FRACTION', 'FATES_WOOD_PRODUCT', diff --git a/cime_config/usermods_dirs/fates_sp/user_nl_clm b/cime_config/usermods_dirs/fates_sp/user_nl_clm index f2f68eb74c..4987eae969 100644 --- a/cime_config/usermods_dirs/fates_sp/user_nl_clm +++ b/cime_config/usermods_dirs/fates_sp/user_nl_clm @@ -6,6 +6,7 @@ use_lch4 = .false. fates_spitfire_mode = 0 use_fates_fixed_biogeog = .true. use_fates_nocomp = .true. +hist_ndens = 1 ! Turn off a list of fields that are not needed for FATES-SP mode hist_fexcl1 = 'FATES_TRIMMING', 'FATES_COLD_STATUS', 'FATES_DROUGHT_STATUS', 'FATES_GDD', 'FATES_NCHILLDAYS', 'FATES_NCOLDDAYS', 'FATES_DAYSINCE_COLDLEAFOFF', 'FATES_DAYSINCE_COLDLEAFON', 'FATES_DAYSINCE_DROUGHTLEAFOFF', From ebf9601621f4b2a162bb2b2bef75c59b06a736ee Mon Sep 17 00:00:00 2001 From: Gregory Lemieux Date: Fri, 26 May 2023 15:27:07 -0700 Subject: [PATCH 2/3] update changelog --- doc/ChangeLog | 68 +++++++++++++++++++++++++++++++++++++++++++++++++++ doc/ChangeSum | 1 + 2 files changed, 69 insertions(+) diff --git a/doc/ChangeLog b/doc/ChangeLog index a620f38209..937e686014 100644 --- a/doc/ChangeLog +++ b/doc/ChangeLog @@ -1,4 +1,72 @@ =============================================================== +Tag name: ctsm5.1.dev128 +Originator(s): glemieux (Gregory Lemieux,LBL/NGEET,510-486-5049) +Date: Fri May 26 15:45:00 MDT 2023 +One-line Summary: Update FATES tests to double precision + +Purpose and description of changes +---------------------------------- + +This pull request updates the fates tests to set the output +precision to double precision. The usermod fates_sp is similarly +updated. + + +Significant changes to scientifically-supported configurations +-------------------------------------------------------------- + +Does this tag change answers significantly for any of the following physics configurations? +(Details of any changes will be given in the "Answer changes" section below.) + +[ ] clm5_1 + +[ ] clm5_0 + +[ ] ctsm5_0-nwp + +[ ] clm4_5 + + +Bugs fixed or introduced +------------------------ + +CTSM issues fixed (include CTSM Issue #): +- Resolves https://github.com/ESCOMP/CTSM/issues/1986 + +Testing summary: +---------------- + + [PASS means all tests PASS; OK means tests PASS other than expected fails.] + + regular tests (aux_clm: https://github.com/ESCOMP/CTSM/wiki/System-Testing-Guide#pre-merge-system-testing): + + cheyenne ---- OK + izumi ------- OK + + fates tests: (give name of baseline if different from CTSM tagname, normally fates baselines are fates--) + cheyenne ---- OK + izumi ------- OK + +If the tag used for baseline comparisons was NOT the previous tag, note that here: + + FATES tests run against fates-sci.1.65.6_api.25.4.0-ctsm5.1.dev127 baseline + +Answer changes +-------------- + +Changes answers relative to baseline: Yes, but only for fates tests and compsets + + Summarize any changes to answers, i.e., + - Differences are due to changing hist_ndens to 1 (double precision) + +Other details +------------- + +Pull Requests that document the changes (include PR ids): +https://github.com/ESCOMP/CTSM/pull/2010 + +=============================================================== +=============================================================== Tag name: ctsm5.1.dev127 Originator(s): sacks (Bill Sacks) Date: Fri May 19 04:48:30 MDT 2023 diff --git a/doc/ChangeSum b/doc/ChangeSum index ca203e6f21..69357c6d66 100644 --- a/doc/ChangeSum +++ b/doc/ChangeSum @@ -1,5 +1,6 @@ Tag Who Date Summary ============================================================================================================================ + ctsm5.1.dev128 glemieux 05/26/2023 Update FATES tests to double precision ctsm5.1.dev127 sacks 05/19/2023 Fix nuopc cplhist test ctsm5.1.dev126 jpalex 05/18/2023 Clean up some loops in UrbanTimeVarType ctsm5.1.dev125 jpalex 05/17/2023 Added cache for clock step_size in clm_time_manager.F90 From cc333285d4c37a0aa0e33220fe2cfa355348092a Mon Sep 17 00:00:00 2001 From: Erik Kluzek Date: Thu, 1 Jun 2023 15:32:53 -0600 Subject: [PATCH 3/3] Update the time stamps --- doc/ChangeLog | 2 +- doc/ChangeSum | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/ChangeLog b/doc/ChangeLog index 937e686014..ced4fc388e 100644 --- a/doc/ChangeLog +++ b/doc/ChangeLog @@ -1,7 +1,7 @@ =============================================================== Tag name: ctsm5.1.dev128 Originator(s): glemieux (Gregory Lemieux,LBL/NGEET,510-486-5049) -Date: Fri May 26 15:45:00 MDT 2023 +Date: Thu Jun 1 15:31:52 MDT 2023 One-line Summary: Update FATES tests to double precision Purpose and description of changes diff --git a/doc/ChangeSum b/doc/ChangeSum index 69357c6d66..aca77a5238 100644 --- a/doc/ChangeSum +++ b/doc/ChangeSum @@ -1,6 +1,6 @@ Tag Who Date Summary ============================================================================================================================ - ctsm5.1.dev128 glemieux 05/26/2023 Update FATES tests to double precision + ctsm5.1.dev128 glemieux 06/01/2023 Update FATES tests to double precision ctsm5.1.dev127 sacks 05/19/2023 Fix nuopc cplhist test ctsm5.1.dev126 jpalex 05/18/2023 Clean up some loops in UrbanTimeVarType ctsm5.1.dev125 jpalex 05/17/2023 Added cache for clock step_size in clm_time_manager.F90