Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some testmods for FATES to test some different FATES parameter file options #2151

Open
2 of 4 tasks
ekluzek opened this issue Sep 11, 2023 · 7 comments
Open
2 of 4 tasks
Assignees
Labels
enhancement new capability or improved behavior of existing capability testing additions or changes to tests

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Sep 11, 2023

As a first step in moving toward #2126 we want to create some testmod directories with shell_commands that do ncgen on the FATES cdl file and then modify it using the FATES tools in order to test some different switches on the FATES parameter file.

Definition of Done:

@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability type: -discussion testing additions or changes to tests labels Sep 11, 2023
@ekluzek
Copy link
Collaborator Author

ekluzek commented Sep 11, 2023

It would be good to show proof of concept for this by doing a simple PR that just adds one simple testmod with the simplest modification possible.

@glemieux
Copy link
Collaborator

The upcoming seed dispersal PR #2077 will be a good use of this.

Also size and age dependent mortality have undefined values in the default parameter file and don't engage until they've been given reasonable values.

@rgknox would the different model switches in the parameter file (e.g. fates_maintresp_leaf_model, fates_regeneration_model, etc) be good candidates to test as well?

@rgknox
Copy link
Collaborator

rgknox commented Sep 13, 2023

We have a bunch of module switches that would be good candidates. I'm ordering these in order of complexity, I think its best to get tests going on those that have the most complexity. The regeneration model, especially with the light mortality dynamics is the most complicated.

fates_regeneration_model
fates_leaf_photo_tempsens_model
fates_allom_fnrt_prof_mode
fates_hydro_htftype_node (UPDATE: maybe avoid this one in the first set)
fates_rad_model (Note: not on fates main branch yet)

fates_maintresp_leaf_model
fates_leaf_stomatal_model

fates_leaf_stomatal_assim_model

It would be nice to test these in the future for longer tests
fates_maxcohort
fates_maxpatch_primary

@glemieux
Copy link
Collaborator

During discussion today @rgknox noted that if we address #1277 we could reduce the time to stress test some of the run modes that need more structure.

Also see NGEET/fates#846 and #1685

@glemieux
Copy link
Collaborator

glemieux commented Oct 13, 2023

Per discussion today, we agreed that we should try and create a PR to develop testmods of all of the above with the exception of the long term tests (maxpatch) and hydro. @rgknox to add the relevant testmod to the API update that will come along with two-stream.

@glemieux glemieux self-assigned this Oct 13, 2023
@ekluzek
Copy link
Collaborator Author

ekluzek commented Oct 13, 2023

@glemieux thanks for the list of tasks from the discussion. To make it easier to see, I'm going to move it to the top and add it as "definition of done".

@glemieux
Copy link
Collaborator

Item 1 in the definition of done will be complete via 2896889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new capability or improved behavior of existing capability testing additions or changes to tests
Development

No branches or pull requests

4 participants