Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some cleanup for arctic luna changes #1399

Closed
ekluzek opened this issue Jun 11, 2021 · 3 comments · Fixed by #1164
Closed

Some cleanup for arctic luna changes #1399

ekluzek opened this issue Jun 11, 2021 · 3 comments · Fixed by #1164
Assignees
@ekluzek
Labels
bfb bit-for-bit code health improving internal code structure to make easier to maintain (sustainability)
Milestone
ctsm5.1.0

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Jun 11, 2021 •
edited
Loading

There were some comments from #947 that didn't make it into the final PR #990.

Make onset_thresh a logical rather than a real. This should cleanup the logic around this...

#947 (comment)

Move some constants to parameter file. Improve some of the logic.

#947 (comment)

Change soila10 from patch to column

#947 (comment)

Another parameter

#947 (comment)
@ekluzek ekluzek added code health improving internal code structure to make easier to maintain (sustainability) tag: simple bfb labels Jun 11, 2021
@ekluzek ekluzek self-assigned this Jun 11, 2021
@ekluzek
Copy link
Collaborator Author

ekluzek commented Jun 11, 2021

Here's a summary of the comments...

#947 (comment)

@ekluzek ekluzek mentioned this issue Jun 11, 2021
Merged
@ekluzek ekluzek added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Jun 24, 2021
@ekluzek
Copy link
Collaborator Author

ekluzek commented Jun 25, 2021

I'm making the part about is_cold_type its own issue #1409 since this will be a change to answers and will need to be scientifically evaluated.

@wwieder wwieder assigned wwieder and unassigned ekluzek Jun 25, 2021
@wwieder wwieder added this to the ctsm5.1.0 milestone Jun 25, 2021
@wwieder wwieder removed their assignment Jun 25, 2021
@ekluzek ekluzek self-assigned this Jun 27, 2021
@billsacks billsacks removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Jul 1, 2021
@ekluzek
Copy link
Collaborator Author

ekluzek commented Aug 4, 2021

I think I've covered all of this now in #1164.

@samsrabin samsrabin added simple bfb bit-for-bit labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ekluzek ekluzek

Labels
bfb bit-for-bit code health improving internal code structure to make easier to maintain (sustainability)
Projects
None yet
Milestone
ctsm5.1.0
Development

Successfully merging a pull request may close this issue.

Some more hardcoded parameters to the params file olyson/ctsm
4 participants
@billsacks @wwieder @samsrabin @ekluzek