convert CLUBB lat/lon crash report from radians to degrees #971
Assignees
Labels
enhancement
New feature or request
Comments
|
I recall that when the new externals came in, allowing passing pcol arrays to clubb, that the errors message only spits out the range of lat/lon points given by the pcol array, rather than the actual pcol index and lat/lon point of the error. Am I mistaken? |
|
If I understand your question yes it still gives a range. But I think the range is in radians. |
Katetc
added a commit
that referenced
this issue
Apr 12, 2024
cam6_3_155: Update CLUBB and SILHS externals New code with some adjustments for the TAUs tuning options. Could be a place to address or discuss #953 Possibly another UWM CLUBB branch tag coming in the next week or so, but no changes to CAM code will be required for that, so we should be able to start the code reviews now. This does change answers for all CAM6 and cam_dev compsets. I made a 1 year comparison run against cam6_3_145 to see the impact of the new external and it seems low: Diagnostics Here @bstephens82 would be good to keep abreast here. Closes #956 Closes #971 Closes #953
gold2718
pushed a commit
to gold2718/CAM
that referenced
this issue
May 2, 2024
Merge pull request ESCOMP#960 from Katetc/Kate/new_clubb_112923 cam6_3_155: Update CLUBB and SILHS externals New code with some adjustments for the TAUs tuning options. Could be a place to address or discuss ESCOMP#953 Possibly another UWM CLUBB branch tag coming in the next week or so, but no changes to CAM code will be required for that, so we should be able to start the code reviews now. This does change answers for all CAM6 and cam_dev compsets. I made a 1 year comparison run against cam6_3_145 to see the impact of the new external and it seems low: Diagnostics Here @bstephens82 would be good to keep abreast here. Closes ESCOMP#956 Closes ESCOMP#971 Closes ESCOMP#953 ESCOMP commit: f942c96
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the feature/what would you like to discuss?
Currently if CLUBB crashes with a fatal error in the CLUBB library, it outputs the lat/lon of the error, but it is output in radians. It would be nice if this were output in degrees. And ideally, it would also be nice if the longitude was output from -180 to +180 instead of from 0 to 360.
I spoke with @Katetc and she indicated this would probably be easy enough to implement as part of her current PR for the new CLUBB external.
Is there anyone in particular you want to be part of this conversation?
@Katetc
Will this change (regression test) answers?
No
Will you be implementing this enhancement yourself?
No
The text was updated successfully, but these errors were encountered: