-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement run phase and dynamics-physics coupling for MPAS dynamical core #304
base: development
Are you sure you want to change the base?
Implement run phase and dynamics-physics coupling for MPAS dynamical core #304
Conversation
MPAS dynamical core can now integrate the dynamical states with time.
This functionality is intended for use by dynamics-physics coupling.
This helper function reverses the order of elements in a 1-d array.
This makes the assignments less error-prone and much more intuitive.
This subroutine provides a streamlined mechanism for exchanging constituent states between CAM-SIMA and MPAS.
Use the new `dyn_exchange_constituent_state` subroutine to perform default initialization for all constituents instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the new MPAS coupling infrastructure @kuanchihwang, and apologies for the review delay! I have some questions and change requests, but hopefully they are all either easy to implement or can be pushed off to a future PR. Of course if you have any questions or concerns with anything I suggested just let me know!
This assumption does not always hold.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for responding to my questions and review requests @kuanchihwang! Everything looks good to me now.
@kuanchihwang Just FYI that @PeterHjortLauritzen is going to look over the dyn-phys coupling just to make sure the science all seems reasonable. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in this PR look good to me. I was able to run a 120-km FKESSLER case, and aside from some differences in the w
field when comparing with CAM-MPAS (which I think may be attributable to reasons other than any issues in this PR), the results seemed to be in general agreement.
Tag name (required for release branches):
None
Originator(s):
kuanchihwang
Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue number):
Implement run (i.e., time integration) phase and dynamics-physics coupling for MPAS dynamical core. CAM-SIMA with MPAS dynamical core is now able to run toward the end successfully.
Describe any changes made to build system:
None
Describe any changes made to the namelist:
None
List any changes to the defaults for the input datasets (e.g. boundary datasets):
None
List all files eliminated and why:
None
List all files added and what they do:
A src/dynamics/mpas/dyn_coupling.F90
List all existing files that have been modified, and describe the changes:
M src/dynamics/mpas/driver/dyn_mpas_subdriver.F90
M src/dynamics/mpas/dyn_comp.F90
dyn_run
use
statements and add commentsreverse
reverse
dyn_exchange_constituent_state
dyn_exchange_constituent_state
M src/dynamics/mpas/stepon.F90
use
statements and adjust indentationdyn_run
Test steps:
Observe log entries similar to the following in
atm.log.<job-id>.<date>-<time>
. Also observe that CAM-SIMA with MPAS dynamical core is now able to run toward the end successfully.