Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-set filters do not show up in chips in inline mode #1365

Closed
viktoraronfarkas opened this issue Nov 14, 2024 · 2 comments · Fixed by #1407
Closed

Pre-set filters do not show up in chips in inline mode #1365

viktoraronfarkas opened this issue Nov 14, 2024 · 2 comments · Fixed by #1407
Assignees
Labels
bug Something isn't working itemfilter

Comments

@viktoraronfarkas
Copy link
Collaborator

viktoraronfarkas commented Nov 14, 2024

When setting the pre-set filters in the itemfilter in inline mode, the chips are not rendered, only the selection is when the filter is opened.

Screenshot 2024-11-14 at 15 28 48

Update: It seems to work with the range filter.
Screenshot 2024-11-14 at 16 35 09

@viktoraronfarkas viktoraronfarkas added bug Something isn't working itemfilter labels Nov 14, 2024
@silvester-pari
Copy link
Collaborator

silvester-pari commented Nov 14, 2024

This is indeed a bug, it should actually recognize that a state has been set by the developer and set the dirty proeprty correctly.

In the meantime, as a workaround, you can manually set the dirty property:

        {
          key: "code",
          title: "Codes",
          type: "multiselect",
          placeholder: "Search codes",
          expanded: true,
          dirty: true, // set this! when we fix it, this should be set automatically
          state: {
            E10a2: true,
          },
        },

@StefanBrand
Copy link
Member

Proposed workaround does not work for certain filter types:

  • range: has no dirty property (functional)
  • spatial: does not print geometry type in chip (cosmetic)
    image

@srijitcoder srijitcoder linked a pull request Dec 4, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working itemfilter
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants