Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chip disappears when min and max values are selected in Itemfilter inline mode #1331

Open
viktoraronfarkas opened this issue Oct 24, 2024 · 1 comment
Labels
bug Something isn't working itemfilter

Comments

@viktoraronfarkas
Copy link
Collaborator

The chip disappears when we set both ends of the slider to the previously configured bounds.

Screen.Recording.2024-10-24.at.16.23.24.mov
@viktoraronfarkas viktoraronfarkas added bug Something isn't working itemfilter labels Oct 24, 2024
@silvester-pari
Copy link
Collaborator

This is currently on purpose, as if the min and max match the initial min&max, then no filtering is happening for this specific filter (it lets through all items anyways, so it is considered not "dirty" or "active" anymore):

// Reset the component if the state matches the original min and max values, otherwise request an update
if (
min === EOxItemFilterRange.filterObject.min &&
max === EOxItemFilterRange.filterObject.max
)
EOxItemFilterRange.reset();
else EOxItemFilterRange.requestUpdate();

What would you expect to behave differently in this case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working itemfilter
Projects
None yet
Development

No branches or pull requests

2 participants