Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Added Integration Tests to Buildkite Pipeline #494

Merged
merged 15 commits into from
Jul 9, 2019

Conversation

kj4ezj
Copy link
Contributor

@kj4ezj kj4ezj commented Apr 12, 2019

Change Description

This pull request is a culmination of three related changes.

Integration Tests

When CDT is built in the presence of EOSIO, which itself has been built and installed from source, the CDT build generates additional integration tests. I have added steps to the CDT Buildkite pipeline to build in the presence of EOSIO and run these integration tests.

These changes rely upon the dependencies file in the root of CDT, and upon the tests registered with ctest being labeled. Thus, I have added a dependencies file exactly like the one in eosio.contracts, and added test labels.

Pipeline Configuration File

I have added the universal pipeline configuration file, pipeline.jsonc, described in pull request 512 and auto-buildkite-pipelines pull request 99. This replaces the dependencies file described above.

sccache Support

I have added support for sccache to accelerate CDT build times in Buildkite. I also added support for sccache to EOSIO LLVM in pull request 23, but Larry has asked me to hold off on updating the submodule as a part of this pull request because of work John is doing. We will merge this pull request as-is, and the submodule will get updated later.

Tested

Base Case (original pipeline):

New Pipeline:

You can see in build 253 that CDT integration tests run correctly but are failing. They are currently disabled by default in the pipeline, but are supported and can be run using:
New Build > Options > Environment Variables > SKIP_INTEGRATION_TESTS='false'

API Changes

  • API Changes
    None.

Documentation Additions

  • Documentation Additions
    None.

@kj4ezj kj4ezj mentioned this pull request Apr 12, 2019
2 tasks
@kj4ezj kj4ezj mentioned this pull request Apr 12, 2019
2 tasks
@kj4ezj kj4ezj marked this pull request as ready for review April 18, 2019 00:14
@kj4ezj kj4ezj requested a review from larryk85 April 18, 2019 20:40
Copy link
Contributor

@larryk85 larryk85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the change is too tools/lld can you please ensure that no submodule shifts have occured with this.

@larryk85 larryk85 merged commit 34c6535 into develop Jul 9, 2019
@larryk85 larryk85 deleted the zcb-integration-tests branch July 9, 2019 18:28
rise-worlds pushed a commit to potato-coin/eosio.cdt that referenced this pull request Jul 14, 2020
Added Integration Tests to Buildkite Pipeline
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants