This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 290
Added Integration Tests to Buildkite Pipeline #494
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 16, 2019
2 tasks
This was referenced May 11, 2019
…supported compiler
…r linking in general
larryk85
suggested changes
Jun 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what the change is too tools/lld
can you please ensure that no submodule shifts have occured with this.
larryk85
approved these changes
Jul 9, 2019
rise-worlds
pushed a commit
to potato-coin/eosio.cdt
that referenced
this pull request
Jul 14, 2020
Added Integration Tests to Buildkite Pipeline
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This pull request is a culmination of three related changes.
Integration Tests
When CDT is built in the presence of EOSIO, which itself has been built and installed from source, the CDT build generates additional integration tests. I have added steps to the CDT Buildkite pipeline to build in the presence of EOSIO and run these integration tests.
These changes rely upon the dependencies file in the root of CDT, and upon the tests registered with ctest being labeled. Thus, I have added a dependencies file exactly like the one in eosio.contracts, and added test labels.
Pipeline Configuration File
I have added the universal pipeline configuration file,
pipeline.jsonc
, described in pull request 512 and auto-buildkite-pipelines pull request 99. This replaces the dependencies file described above.sccache Support
I have added support for sccache to accelerate CDT build times in Buildkite. I also added support for sccache to EOSIO LLVM in pull request 23, but Larry has asked me to hold off on updating the submodule as a part of this pull request because of work John is doing. We will merge this pull request as-is, and the submodule will get updated later.
Tested
Base Case (original pipeline):
New Pipeline:
You can see in build 253 that CDT integration tests run correctly but are failing. They are currently disabled by default in the pipeline, but are supported and can be run using:
New Build > Options > Environment Variables >
SKIP_INTEGRATION_TESTS='false'
API Changes
None.
Documentation Additions
None.