Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

add a dockerignore file ignoring .git directory #9966

Merged
merged 1 commit into from
Feb 20, 2021

Conversation

spoonincode
Copy link
Contributor

Change Description

This decreases the docker context ~600MB. I think safe to do?

Change Type

Select ONE:

  • Documentation
  • Stability bug fix
  • Other
  • Other - special case

Testing Changes

Select ANY that apply:

  • New Tests
  • Existing Tests
  • Test Framework
  • CI System
  • Other

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

Copy link
Contributor

@scottarnette scottarnette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine. I don't imagine any storage benefits from this since we don't copy the build context in any of our containers. At the very least, this will slightly decrease build times when base images are refreshed.

@spoonincode
Copy link
Contributor Author

agreed, no real benefit for CI. Mainly was nice when I did a docker build locally to save some time

@spoonincode spoonincode merged commit c5746b7 into develop Feb 20, 2021
@spoonincode spoonincode deleted the docker_ignore_git branch February 20, 2021 03:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants