This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
refactor get_kv_table_rows #9964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huangminghuang
force-pushed
the
huangminghuang/refactor-kv-get-rows
branch
from
7b8637e to
654a10a
Compare
brianjohnson5972
suggested changes
Feb 2, 2021
libraries/chain/include/eosio/chain/backing_store/kv_context_chainbase.hpp
Outdated
Show resolved
Hide resolved
libraries/chain/include/eosio/chain/backing_store/kv_context_chainbase.hpp
Outdated
Show resolved
Hide resolved
libraries/chain/include/eosio/chain/backing_store/kv_context_rocksdb.hpp
Outdated
Show resolved
Hide resolved
| fc::variant get_value_and_maybe_payer_var(fc::time_point cur_time) const { | ||
| fc::variant result = get_value_var(cur_time); | ||
| if (context.p.show_payer) { | ||
| auto maybe_payer = base->kv_it_payer(); |
There was a problem hiding this comment.
I think we should just assume payer is there, or else we should assert, since the only reason kv_it_payer doesn't return a payer is if kv_it_value wasn't called first.
huangminghuang
force-pushed
the
huangminghuang/refactor-kv-get-rows
branch
from
df5cd47 to
0b0bd24
Compare
brianjohnson5972
approved these changes
Feb 2, 2021
this matches the query for for db table
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This PR refactors read_only::get_kv_table_rows and fixes the following problems
Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions