Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix or inhibit various compiler warnings while building on clang. #9831

Merged
merged 6 commits into from
Jan 5, 2021

Conversation

TimothyBanks
Copy link
Contributor

@TimothyBanks TimothyBanks commented Dec 23, 2020

Change Description

There were a few compiler warnings occurring while building eos on clang:

  • There were a few warning pragmas within the code. I removed those and created JIRA issues to address them.
  • A few 3rdParty libraries not maintained by block.one produce various compiler warnings when built on clang. I decided to inhibit all compiler warnings in those projects.
  • The build produced quite a few ld: warning: direct access in weak symbol. I eliminated the majority of them by changing the default symbol visibility to hidden. There are still a couple that are being generated when linking against libpqxx because it seems that library isn't using hidden by default.

Change Type

Select ONE:

  • Documentation
  • Stability bug fix
  • Other
  • Other - special case

Testing Changes

Select ANY that apply:

  • New Tests
  • Existing Tests
  • Test Framework
  • CI System
  • Other

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@TimothyBanks TimothyBanks changed the title Fix or inhibit variois compiler warnings while building on clang. Fix or inhibit various compiler warnings while building on clang. Dec 23, 2020
Copy link
Contributor

@linhuang-blockone linhuang-blockone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be helpful to list the JIRAs here?

@TimothyBanks
Copy link
Contributor Author

I was told not to list JIRAs in the PR. But there is only one JIRA issue for resolving the compilation warnings on MacOS.

@TimothyBanks TimothyBanks merged commit ae1800b into develop Jan 5, 2021
@TimothyBanks TimothyBanks deleted the fix-compiler-warnings branch January 5, 2021 19:45
@huangminghuang huangminghuang mentioned this pull request Nov 1, 2021
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants