Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

[docs] update docs to reflect updated code using 128MiB #9695

Merged
merged 6 commits into from
Dec 10, 2020

Conversation

halsaphi
Copy link
Contributor

Change Description

Update to docs - zero impact to code base.

Change Type

Select ONE

  • [x ] Documentation
  • Stability bug fix
  • Other
  • Other - special case

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • [x ] Documentation Additions

@iamveritas iamveritas added the documentation Requires attention from documentation team. e.g. documentation is expected to be generated. label Nov 19, 2020
@iamveritas iamveritas changed the title update docs to reflect updated code using 128MiB [docs] update docs to reflect updated code using 128MiB Nov 19, 2020
@allenhan2
Copy link
Contributor

"Philip Halsall" doesn't have permission to trigger builds in "EOSIO Sync from Genesis",
could any sponsor of granting the permission to fire a service ticket? thanks,

@halsaphi halsaphi requested review from heifner and gssagoo November 23, 2020 05:00
Copy link
Contributor

@lparisc lparisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes:

  • Wrap the config options in codeblocks ``` ... ``` to render properly. It currently renders like this:
    "--backing-store arg (=chainbase) The storage for state, chainbase or rocksdb --rocksdb-threads arg Number of rocksdb threads for flush and compaction. Defaults to the number of available cores. --rocksdb-files arg (=-1) Max number of rocksdb files to keep open. -1 = unlimited. --rocksdb-write-buffer-size-mb arg (=128) Size of a single rocksdb memtable (in MiB)"
  • Complete "Next Steps" section or remove title for now.
  • docs/01_nodeos/02_usage/index.md must be updated to include the new 60_how-to-guides section

Copy link

@gssagoo gssagoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@halsaphi halsaphi requested a review from heifner November 27, 2020 03:38
Copy link

@gssagoo gssagoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to removing MiB from the --persistent-storage-write-buffer-size-mb parameter looks good. Also the comment change reflecting that we no longer default to the number of cores for --persistent-storage-num-threads looks good. thanks

@halsaphi
Copy link
Contributor Author

halsaphi commented Dec 7, 2020

re "docs/01_nodeos/02_usage/index.md must be updated to include the new 60_how-to-guides section" this doesn't match cleos and keod sections though ... should this be discussed?

Added something for you to review.

@halsaphi halsaphi merged commit cddd476 into develop Dec 10, 2020
@halsaphi halsaphi deleted the docs-dev-mb-update branch December 10, 2020 05:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Requires attention from documentation team. e.g. documentation is expected to be generated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants