fix get_table_rows_by_seckey conversion

[kimjh2005]

Change Description

fixed function get_table_rows_by_seckey converts lower and upper value in eosio::name incorrectly.

Change Type

Select ONE

• Documentation

• Stability bug fix

• Other

• Other - special case

Consensus Changes

• Consensus Changes

API Changes

• API Changes

Documentation Additions

• Documentation Additions

[dimas1185]

can you explain why get_table_rows_by_seckey was working incorrectly if you used string representation of name instead of string representaton of underlying integer?

[kimjh2005]

convert_to_type calls boost::lexical_cast<uint64_t>( str.c_str())
Before the fix, lexical_cast<uint64_t>("1111" ) is called,
After the fix, lexical_cast<uint64_t>("1324356665524535") is called. //"1324356665524535" is eosio::name in uint64_t string.

The return value is:
Before the fix is 1111,
After the fix is eosio::name in uint64_t number.

template<>
uint64_t convert_to_type(const string& str, const string& desc) {
try {
return boost::lexical_cast<uint64_t>(str.c_str(), str.size());
} catch( ... ) { }

[dimas1185]

@kimjh2005 that is understood. I don't get why lexical_cast<uint64_t>("1111" ) is an issue. it should return valid value, isn't it? so why raw uint64 representation is preferred?

[kimjh2005]

the return value 1111 is not correct value for eosio::name for "1111"_n. It should have uint64_t number which is not 1111.

[dimas1185]

@kimjh2005 eosio::chain::name "1111"_n is valid name. However I looked in the code and I understood why it fails. I'll propose some alternative solution inline in comments.

[dimas1185]

I don't think you need L-value here. This should work as long as reference is const:

SecKeyType lv = convert_to_type({p.lower_bound}, "lower_bound name");

I misread the change