This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
[1.7.x] Increase Contracts Builder Timeout + Fix $SKIP_MAC + Fix hard-coded build command #7850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottarnette
changed the title
arhag
approved these changes
Sep 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This pull request fixes two problems we found in Buildkite pipeline 3.0. The first is a missing
SKIP_MACvariable on the Brew Updater step, causing that step to fail any builds started withSKIP_MAC='true'. The second problem was that the Contracts Builder step had a timeout of 10 minutes, but took about 10 minutes to run. The default timeout for that step has been increased to 30 minutes.1.7 has an additional fix impacting
.cicd/build.sh. Linux builds previously had a hard-coded COMMANDS variable. This worked appropriately when only performing a build, but was incorrect for the Contract Builder step. This script now runs cmake, make, and make install with the appropriately determined CMAKE_FLAGS.Tested
Consensus Changes
API Changes
Documentation Additions