fix 7600 double confirm after changing sign key #7601

taokayan · 2019-07-05T10:03:53Z

Change Description

This fix #7600 double confirm bug after changing signing key which results in producing by different nodeos

No. Changes are subjective.

No

No

arhag

The PR also needs a Python test to ensure changing block signing keys back and forth doesn't not lead to the problem described in issue #7600.

plugins/producer_plugin/producer_plugin.cpp

programs/eosio-launcher/main.cpp

plugins/producer_plugin/producer_plugin.cpp

tests/nodeos_producer_watermark_test.py

arhag

Also make a version of this PR for develop.

taokayan added 2 commits July 5, 2019 17:55

fix 7600 double confirm after changing sign key

098d06b

simplify watermark, add lib check

ae49c04

arhag suggested changes Jul 8, 2019

View reviewed changes

plugins/producer_plugin/producer_plugin.cpp Outdated Show resolved Hide resolved

simplify watermark, add python test

a47e4fe

arhag suggested changes Jul 9, 2019

View reviewed changes

fix 7600, test case

73983bf

arhag approved these changes Jul 18, 2019

View reviewed changes

arhag merged commit de18961 into release/1.8.x Jul 19, 2019

arhag deleted the kayan_signkey branch July 19, 2019 18:23