This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
reenable building of mongo c/cxx drivers #7218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larryk85
reviewed
Apr 26, 2019
Appears to be a goof from merging back and forth; have been maintaining this patch set since way before those other changes were made. |
spoonincode
force-pushed
the
hello_mongo
branch
from
be5157b to
bb3cbe7
Compare
spoonincode
force-pushed
the
hello_mongo
branch
from
bb3cbe7 to
9ba2952
Compare
Gotcha. |
larryk85
reviewed
Apr 26, 2019
larryk85
previously approved these changes
Apr 26, 2019
…ingly pick up a static library from elsewhere
spoonincode
force-pushed
the
hello_mongo
branch
from
3bcc29e to
f2208a9
Compare
larryk85
approved these changes
Apr 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Reenable building of mongo c/cxx drivers and include support for building them within the confines of the pinned compiler (meaning they're included in binaries and such)
warning 1: I don't pin the compiler for the macos build because we're already not pinning it for boost build 🤷♂️
warning 2: I had to downgrade the test VM image version so that mongod was available to run during tests
Consensus Changes
API Changes
Documentation Additions