This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Move json::to_string response processing to http thread pool #6893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
fc::variant
to JSON string reponse into the http thread pool to reduce the amount of work done on the application thread.Consensus Changes
API Changes
url_response_callback
changed fromstd::function<void(int,std::string)>
tostd::function<void(int,fc::variant)>
-- Code calling the url_response_callback is now expected to provide a
fc::variant
instead of a string. This means the the type must be setup withFC_REFLECT
so it can be converted to variant. This was already the case for all plugins ineos
repo, but if external plugins were doing their own json conversion then that will no longer work.Documentation Additions