Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Move json::to_string response processing to http thread pool #6893

Merged
merged 2 commits into from
Mar 11, 2019

Conversation

heifner
Copy link
Contributor

@heifner heifner commented Mar 7, 2019

Change Description

Consensus Changes

API Changes

  • The http_plugin url_response_callback changed from std::function<void(int,std::string)> to std::function<void(int,fc::variant)>
    -- Code calling the url_response_callback is now expected to provide a fc::variant instead of a string. This means the the type must be setup with FC_REFLECT so it can be converted to variant. This was already the case for all plugins in eos repo, but if external plugins were doing their own json conversion then that will no longer work.

Documentation Additions

@heifner heifner merged commit c1c86ae into develop Mar 11, 2019
@heifner heifner deleted the http-gh#6891 branch March 11, 2019 17:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants