This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
fix switching between speculative and irreversible mode #6842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arhag
suggested changes
Feb 28, 2019
…replay. No longer reconstruct reversible blocks when switching from irreversible to speculative mode since that can be dangerous. Instead use maybe switch forks after the replay is complete.
…en applying best branch from fork_db
…will exist while in irreversible mode
arhag
approved these changes
Mar 6, 2019
This was referenced Apr 17, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This fixes the switches between irreversible mode and speculative mode, with or without replay flag. see #6704
Consensus Changes
No.
API Changes
No.
Documentation Additions
No.